Skip to content

Update to latest package references, runtime framework, and SDK #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 4 commits into from
Aug 31, 2018
Merged

Update to latest package references, runtime framework, and SDK #7646

TravisEz13 merged 4 commits into from
Aug 31, 2018

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Aug 28, 2018

PR Summary

Move to sdk2.1.401, runtime 2.1.3 and update package references.

PR Checklist

@iSazonov iSazonov self-assigned this Aug 28, 2018
@iSazonov
Copy link
Collaborator Author

iSazonov commented Aug 28, 2018

CI Appveyor failed with "dotnet : A compatible SDK version for global.json version: [2.1.401] from [C:\projects\powershell\global.json] was not found". I don't know how fix this.

Feel free to add commits.

TravisEz13
TravisEz13 requested changes Aug 28, 2018
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files.wxs is still out of sync

@TravisEz13
Copy link
Member

TravisEz13 commented Aug 29, 2018

the mac CI was failing due to a version number being in the TMPDIR I was setting. It looks like VSTS has already fixed this issue, so I removed this workaround.

@iSazonov
Copy link
Collaborator Author

iSazonov commented Aug 29, 2018

@TravisEz13 Thanks for help!
I still see the error in CI Appveyor "dotnet : A compatible SDK version for global.json version: [2.1.401] from [C:\projects\powershell\global.json] was not found"
I think it is the reason that file.wxs is not synced.
I don't know how fix CI Appveyor.

@TravisEz13
Copy link
Member

TravisEz13 commented Aug 29, 2018

That isn't what's causing it to fail. See https://ci.appveyor.com/project/PowerShell/powershell/build/v6.1.0-rc.10858/job/e862tmmuqaww98v0#L1735

@TravisEz13 TravisEz13 merged commit c34d3ef into PowerShell:master Aug 31, 2018
@iSazonov
Copy link
Collaborator Author

iSazonov commented Aug 31, 2018

@TravisEz13 Thanks for help!

@iSazonov iSazonov deleted the move-to-sdk2.1.401 branch August 31, 2018 03:01
@TravisEz13
Copy link
Member

TravisEz13 commented Aug 31, 2018

@iSazonov No problem... I used this to test my new code to generate the wxs file changes.

TravisEz13 pushed a commit that referenced this pull request Aug 31, 2018
@iSazonov @TravisEz13
Update to latest package references, runtime framework, and SDK (#7646)
959ce30 
* Move to .Net Core SDK 2.1.401 and runtime 2.1.3

* Update package references
@TravisEz13 TravisEz13 added this to the v6.1.0 milestone Aug 31, 2018
@iSazonov iSazonov mentioned this pull request Sep 6, 2018
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@dantraMSFT dantraMSFT Awaiting requested review from dantraMSFT

Assignees

@iSazonov iSazonov

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@iSazonov @TravisEz13