Skip to content

Conversation

@britishben
Copy link
Contributor

@britishben britishben commented Aug 24, 2018

PR Summary

I got annoyed that Get-Date -UFormat '%F %T' did not work the same as date +'%F %T', so I've added that case now. Partial fix for issue #7341.

PR Checklist

@msftclas
Copy link

msftclas commented Aug 24, 2018

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@britishben Thanks for your contribution!

@britishben
Copy link
Contributor Author

Thanks @chuanjiao10 - I've taken out the 'P' case now, so the only one of your cases this would solve is the first:

PS /root> get-date -uformat %F ; date +%F
F
2018-07-24

Still, slow progress is better than no progress.

@britishben britishben changed the title WIP: Add two options (%F, %P) to Get-Date -UFormat WIP: Add one option (%F) to Get-Date -UFormat Sep 4, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Sep 4, 2018

@britishben If you don't plan fix %P please update the PR description and remove WIP.

@britishben britishben changed the title WIP: Add one option (%F) to Get-Date -UFormat Add %F option to Get-Date -UFormat Sep 24, 2018
@britishben
Copy link
Contributor Author

@iSazonov Done - thanks for the reminder.

@iSazonov
Copy link
Collaborator

@britishben Please rebase to fix CIs.

@britishben
Copy link
Contributor Author

@iSazonov done, thanks - let me know if you need anything else from me.

@iSazonov
Copy link
Collaborator

Please update package reference to Markdig.Signed 0.15.2 (see failed test)

Microsoft.PowerShell.MarkdownRender.csproj reference to Markdig.Signed 0.15.2

@britishben
Copy link
Contributor Author

@iSazonov I've bumped up the number in src/Microsoft.PowerShell.MarkdownRender/Microsoft.PowerShell.MarkdownRender.csproj to see if that makes a difference, but that's not my error; Looks like a version change from https://github.com/lunet-io/markdig/ (got 15.3, expected 15.2).

You'll probably see the same on all your PRs.

@iSazonov
Copy link
Collaborator

@britishben Yes, it is not your error. We have a test to check package versions. If there is a new version the test fail. We already merged a PR with version updates. So you should rebase.

Update tests to add %F
@britishben
Copy link
Contributor Author

@iSazonov Thanks - done that now.

@iSazonov iSazonov self-assigned this Sep 27, 2018
@iSazonov
Copy link
Collaborator

@anmenaga @TravisEz13 Please review the PR.

@iSazonov
Copy link
Collaborator

@britishben Please open new issue in PowerSehll-Docs repo (or push PR there) to document the enhancement and add a link to the issue to the PR description.

@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Sep 27, 2018
@iSazonov iSazonov merged commit 39252b4 into PowerShell:master Oct 1, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 1, 2018

@britishben Thanks for your contribution!

@britishben britishben deleted the get-date-bpm branch October 1, 2018 15:30
@joeyaiello joeyaiello removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 14, 2018
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 15, 2018
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 16, 2018
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Dec 5, 2018
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Dec 20, 2018
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 6, 2019
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 11, 2019
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 14, 2019
v-alje pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Feb 1, 2019
sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants