Make sure we do not upload artifacts during a pull request #7535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
11 tasks
Collaborator
|
So how can we get artifacts from a PR? |
Member
Author
|
I've opened an issue on VSTS |
dantraMSFT
approved these changes
Aug 16, 2018
build.psm1
Outdated
| $resolvedPath = (Resolve-Path -Path $Path).ProviderPath | ||
| Write-Host "##vso[results.publish type=$Type;mergeResults=true;runTitle=$Title;publishRunAttachments=true;resultFiles=$resolvedPath;]" | ||
| Write-Host "##vso[artifact.upload containerfolder=testResults;artifactname=testResults]$resolvedPath" | ||
| Build.Reason'], 'PullRequest |
Contributor
There was a problem hiding this comment.
I'm not understanding what this line is doing. It appears to be writing to the output stream but it's not clear what it is accomplishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Make sure we do not upload artifacts during a pull request
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests