Updated thread job to version 1.1.2 #7522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dation attribute for Arguments parameter, and made test work with strict mode
PaulHigin
requested review from
TravisEz13,
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
Fixed botched merge.
TravisEz13
approved these changes
Aug 14, 2018
adityapatwardhan
requested changes
Aug 14, 2018
| } | ||
|
|
||
| $numThreadJobs = (Get-Job | where PSJobTypeName -eq "ThreadJob").Count | ||
| $numThreadJobs = @(Get-Job | where PSJobTypeName -eq "ThreadJob").Count |
Member
There was a problem hiding this comment.
Pester 4 syntax has -HaveCount. This can be converted to:
@(Get-Job | where-object { PSJobTypeName -eq "ThreadJob"}) | Should -HaveCount 0
Contributor
Author
There was a problem hiding this comment.
Thanks. Will change.
| } | ||
|
|
||
| $numThreadJobs = (Get-Job | where PSJobTypeName -eq "ThreadJob").Count | ||
| $numThreadJobs = @(Get-Job | where PSJobTypeName -eq "ThreadJob").Count |
Member
There was a problem hiding this comment.
Do not use alias where -> Where-Object
| $null = $job1,$job2,$job3,$job4 | Receive-Job -Wait -AutoRemoveJob | ||
|
|
||
| (Get-Job | where PSJobTypeName -eq "ThreadJob").Count | Should -Be 0 | ||
| @(Get-Job | where PSJobTypeName -eq "ThreadJob").Count | Should -Be 0 |
Member
There was a problem hiding this comment.
Please use -HaveCount.
| $null = $job1,$job2,$job3,$job4 | Receive-Job -Wait -AutoRemoveJob | ||
|
|
||
| (Get-Job | where PSJobTypeName -eq "ThreadJob").Count | Should -Be 0 | ||
| @(Get-Job | where PSJobTypeName -eq "ThreadJob").Count | Should -Be 0 |
|
|
||
| $numRunningThreadJobs = (Get-Job | where { ($_.PSJobTypeName -eq "ThreadJob") -and ($_.State -eq "Running") }).Count | ||
| $numQueuedThreadJobs = (Get-Job | where { ($_.PSJobTypeName -eq "ThreadJob") -and ($_.State -eq "NotStarted") }).Count | ||
| $numRunningThreadJobs = @(Get-Job | where { ($_.PSJobTypeName -eq "ThreadJob") -and ($_.State -eq "Running") }).Count |
adityapatwardhan
approved these changes
Aug 14, 2018
Member
adityapatwardhan
left a comment
adityapatwardhan
left a comment
There was a problem hiding this comment.
Approved with one comment about an alias where
|
|
||
| $numThreadJobs = (Get-Job | where PSJobTypeName -eq "ThreadJob").Count | ||
| $numThreadJobs | Should -Be 0 | ||
| Get-Job | where PSJobTypeName -eq "ThreadJob" | Should -HaveCount 0 |
Member
There was a problem hiding this comment.
Missed one where here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added fix to remove unneeded validation attribute for Arguments parameter, and made tests work with strict mode.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests