Save modules to un-versioned folder to enable servicing #7518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested review from
adityapatwardhan,
anmenaga and
dantraMSFT
as code owners
Member
|
https://github.com/PowerShell/PowerShell/blob/master/assets/files.wxs#L1647 must be updated in various places |
dantraMSFT
approved these changes
Aug 14, 2018
TravisEz13
reviewed
Aug 14, 2018
| <Directory Id="dir9956A485678594F33C936BA160AD06C4" Name="Modules"> | ||
| <Directory Id="dir9C2FC7DD1B408AD4F70123DF50131CBD" Name="PackageManagement"> | ||
| <Directory Id="dirBE29553BD60B3A0392916BB9B7487287" Name="1.1.7.0"> | ||
| <Component Id="cmp06B11EAFDD3914ACF2D8C164DC8690DD" Guid="{9A900A1C-06C8-4BA9-A0D0-C8A0B9A19517}"> |
Member
There was a problem hiding this comment.
Not blocking, but technically you are supposed to change either the component ID or
GUID if you change the file. Since we shouldn't have to produce a patch, it shouldn't matter.
Member
Author
There was a problem hiding this comment.
In that case, I'd prefer not to have to change all those ids.
Member
There was a problem hiding this comment.
Agreed, just mentioning for future reference.
TravisEz13
approved these changes
Aug 14, 2018
11 tasks
TravisEz13
added a commit
that referenced
this pull request
Aug 15, 2018
I missed this in reviewing #7518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove code from build.psm1 that saves the modules to a versioned folder. For servicing reasons after release it is preferred and easier to not have the versioned folder so that we can directly replace modules that need to be serviced (MSI specifically makes it difficult to service a module if the folder path changes).
Fix #7236
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests