Skip to content

Update NuGet package metadata #7517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 2 commits into from
Aug 14, 2018
Merged

Update NuGet package metadata #7517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5fd955
Update NuGet package metadata
adityapatwardhan Aug 13, 2018
fe066b4
Updated description
adityapatwardhan Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions tools/packaging/packaging.strings.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@{
@{
Description = @'
PowerShell is an automation and configuration management platform.
It consists of a cross-platform command-line shell and associated scripting language.
Expand Down Expand Up @@ -109,22 +109,27 @@ OsxDistributionTemplate = @'
'@
NuspecTemplate = @'
<?xml version="1.0" encoding="utf-8"?>
<package
xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>{0}</id>
<version>{1}</version>
<title>PowerShellRuntime</title>
Copy link
Contributor

@dantraMSFT dantraMSFT Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intent to remove the <title> element?

Copy link
Member Author

@adityapatwardhan adityapatwardhan Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to nuget.org documentation having a description is a must, title is not mandatory. Hence, removed it.

<authors>Powershell</authors>
<owners>microsoft,powershell</owners>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<description>PowerShell runtime for hosting PowerShell</description>
<copyright>Copyright (c) Microsoft Corporation. All rights reserved.</copyright>
<language>en-US</language>
<dependencies>
<group targetFramework=".NETCoreApp2.1"></group>
</dependencies>
</metadata>
<package xmlns="http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd">
<metadata>
<id>{0}</id>
<version>{1}</version>
<authors>Microsoft</authors>
<owners>Microsoft,PowerShell</owners>
<requireLicenseAcceptance>true</requireLicenseAcceptance>
<description>PowerShell runtime for hosting PowerShell Core</description>
<projectUrl>https://github.com/PowerShell/PowerShell</projectUrl>
<iconUrl>https://github.com/PowerShell/PowerShell/blob/master/assets/Powershell_black_64.png?raw=true</iconUrl>
<licenseUrl>https://github.com/PowerShell/PowerShell/blob/master/LICENSE.txt</licenseUrl>
<tags>PowerShell</tags>
<language>en-US</language>
<copyright>© Microsoft Corporation. All rights reserved.</copyright>
Copy link
Collaborator

@iSazonov iSazonov Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it important to use © symbol?

Copy link
Member Author

@adityapatwardhan adityapatwardhan Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is a requirement by NuGet.org

<contentFiles>
<files include="**/*" buildAction="None" copyToOutput="true" flatten="false" />
</contentFiles>
<dependencies>
<group targetFramework=".NETCoreApp2.0"></group>
</dependencies>
</metadata>
</package>
'@
RefAssemblyCsProj = @'
Expand Down