Update NuGet package metadata #7517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested review from
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
TravisEz13
reviewed
Aug 13, 2018
| <authors>Microsoft</authors> | ||
| <owners>Microsoft,PowerShell</owners> | ||
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | ||
| <description>Native binaries for PowerShell Core</description> |
Member
Author
|
@TravisEz13 Fixed, please have a look. |
TravisEz13
approved these changes
Aug 14, 2018
iSazonov
reviewed
Aug 14, 2018
| <licenseUrl>https://github.com/PowerShell/PowerShell/blob/master/LICENSE.txt</licenseUrl> | ||
| <tags>PowerShell</tags> | ||
| <language>en-US</language> | ||
| <copyright>© Microsoft Corporation. All rights reserved.</copyright> |
Collaborator
There was a problem hiding this comment.
Is it important to use © symbol?
Member
Author
There was a problem hiding this comment.
Yes it is a requirement by NuGet.org
dantraMSFT
approved these changes
Aug 14, 2018
Contributor
dantraMSFT
left a comment
dantraMSFT
left a comment
There was a problem hiding this comment.
Other than the question about the removal of <title> element, LGTM.
| <metadata> | ||
| <id>{0}</id> | ||
| <version>{1}</version> | ||
| <title>PowerShellRuntime</title> |
Contributor
There was a problem hiding this comment.
Did you intent to remove the <title> element?
Member
Author
There was a problem hiding this comment.
According to nuget.org documentation having a description is a must, title is not mandatory. Hence, removed it.
Member
Author
|
@TravisEz13 Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the nuget package metadata as per nuget.org requirements.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests