build: fix Start-PSBuild -Output #7504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Start-PSBuild -Output $OutDir output the build to the directory properly.
kwkam
requested review from
TravisEz13,
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
adityapatwardhan
approved these changes
Aug 13, 2018
Member
|
Restarted Travis-CI. |
dantraMSFT
suggested changes
Aug 13, 2018
Contributor
dantraMSFT
left a comment
dantraMSFT
left a comment
There was a problem hiding this comment.
I think this needs to be thought through a little more because it's not clear to the user what -Output should contain.
anmenaga
reviewed
Aug 20, 2018
anmenaga
left a comment
anmenaga
left a comment
There was a problem hiding this comment.
- PR description: to me it is not clear what is the current (bad) behavior is / what this PR is fixing. Maybe add a sentence about it or example.
- While you are at it and understand internals it would be great if you could add comments for $Output parameters of functions in build.psm1, describing expected values and behavior.
dantraMSFT
approved these changes
Sep 6, 2018
Member
|
AppVeyor timed out. Restarted it. |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
Collaborator
|
@kwkam Please rebase to pass CIs. |
TravisEz13
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Make Start-PSBuild -Output $OutDir output the build to the directory properly.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests