build: Also search PATH for rcedit #7503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwkam
requested review from
TravisEz13,
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
iSazonov
reviewed
Aug 13, 2018
build.psm1
Outdated
| if (-not (Test-Path "~/.rcedit/rcedit-x64.exe")) { | ||
| $rcedit = "~/.rcedit/rcedit-x64.exe" | ||
| if (-not (Test-Path -Type Leaf $rcedit)) { | ||
| $rcedit = Get-Command rcedit-x64 -ErrorAction SilentlyContinue | Select-Object -First 1 | % Name |
Collaborator
There was a problem hiding this comment.
Should it be Get-Command rcedit-x64.exe -CommandType Application -ErrorAction SilentlyContinue ?
iSazonov
approved these changes
Aug 13, 2018
dantraMSFT
approved these changes
Aug 13, 2018
Member
|
VSTS issue is known and fixed. ignoring since we are still running in parallel with travis-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Allow custom location for
rcedit.exePR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests