Add tests for Import-Module -Force #7491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
approved these changes
Aug 10, 2018
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one comment.
rjmholt
changed the title
Collaborator
Author
|
Sorry @iSazonov, I was demonstrating to some people how to contribute simple tests to the PowerShell repo. But I would actually like to add this test and bunch of others, so I'll add a few more to this and we can make it into a more useful PR. |
Collaborator
|
We could merge this as is. You can make new PR for new tests. |
rjmholt
changed the title
Collaborator
Author
|
@iSazonov Done! |
Collaborator
|
I guess you will add tests for nested module scenarios with |
Collaborator
|
@adityapatwardhan Could you please review? |
adityapatwardhan
requested changes
Aug 30, 2018
Member
There was a problem hiding this comment.
Please remove this line.
Collaborator
|
@rjmholt Please rebase to reconfigure CIs |
rjmholt
force-pushed
the
import-module-force-tests
branch
from
c35b5f2 to
1d7b1f1
Compare
Collaborator
|
@adityapatwardhan Please update your code review. |
adityapatwardhan
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add testing for the behaviour of Import-Module -Force.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests