Add CI definition for VSTS for macOS #7490
Conversation
TravisEz13
requested review from
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
|
There is a bug in VSTS when you first add the definition. The run from my branch is here: https://powershell.visualstudio.com/PowerShell/_build%2Fresults?buildId=258&_a=summary |
Also, to send log files to VSTS on failure
dantraMSFT
left a comment
dantraMSFT
left a comment
There was a problem hiding this comment.
I can sign off on the macos tests and the PSSyslog.psm1 changes.
| } | ||
|
|
||
| Describe 'Basic os_log tests on MacOS' -Tag @('Feature','RequireSudoOnUnix') { | ||
| Describe 'Basic os_log tests on MacOS' -Tag @('Feature','RequireSudoOnUnix','SkipInVsts') { |
There was a problem hiding this comment.
Would you add a comment about why SkipInVsts?
There was a problem hiding this comment.
It should not be needed, I will remove.
vsts-macos-ci.yml
Outdated
| Write-Host "##vso[task.setvariable variable=TMPDIR]$env:AGENT_TEMPDIRECTORY" | ||
| displayName: Set TMPDIR to AGENT_TEMPDIRECTORY | ||
| condition: succeededOrFailed() | ||
There was a problem hiding this comment.
Trailing spaces at line 27 (reported by CodeFactor)
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
LGTM, with a few minor comments.
vsts-macos-ci.yml
Outdated
| Write-Host "##vso[artifact.upload containerfolder=testResults;artifactname=testResults]$_" | ||
| } | ||
| displayName: Publish Test Results | ||
| condition: succeeded() |
There was a problem hiding this comment.
Maybe change to succeededorfailed()
| displayName: Publish Test Results | ||
| condition: succeeded() | ||
| - task: PublishTestResults@2 |
There was a problem hiding this comment.
some comments about this one and the one above would be great.
| @@ -0,0 +1,82 @@ | |||
| name: PR-$(System.PullRequest.PullRequestNumber)-$(Date:yyyyMMdd)$(Rev:.rr) | |||
There was a problem hiding this comment.
It's better to move this file in a folder, like vsts-ci, so we don't have more and more files under the repository root.
There was a problem hiding this comment.
moved to a folder .vsts-ci
3 participants
PR Summary
Add CI definition for VSTS for macOS
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests