Remove WriteVerbose statement from ConvertTo-Json #7487
Conversation
devblackops
requested review from
JamesWTruher,
PaulHigin and
dantraMSFT
as code owners
|
@devblackops I wonder do you see the verbose messages without |
There was a problem hiding this comment.
@devblackops Please also remove the message string which would no longer be used after this pr:
|
@iSazonov The messages aren't shown without It's easy enough to suppress the verbose output with |
|
@markekraus I pushed a commit to remove the resource string. |
dantraMSFT
left a comment
dantraMSFT
left a comment
There was a problem hiding this comment.
I agree the verbose statement doesn't add much value.
It was added when StopProcessing was added so I expect it was done for debugging purposes.
|
@devblackops Thanks for your contribution! |
…erShell#7487)" This reverts commit 8374a5c.
5 participants
PR Summary
Fix #7486.
In PR #6392, a
WriteVerbosestatement was added toConvertTo-Jsonwhich I feel is unnecessary. On large or complex objects being serialized to json, this produces a ton of verbose messages which isn't adding any value to the end user. This PR removes that statement.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests