Skip to content

Update the 'HelpUri' for 'Get-ExperimentalFeature' #7466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Aug 8, 2018
Merged

Update the 'HelpUri' for 'Get-ExperimentalFeature' #7466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1295b8f
Update the 'HelpUri' for 'Get-ExperimentalFeature'
daxian-dbw Aug 6, 2018
22b4543
Address Aditya's comment
daxian-dbw Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/ExperimentalFeature/GetExperimentalFeatureCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.Commands
/// <summary>
/// Implements Get-ExperimentalFeature cmdlet.
/// </summary>
[Cmdlet(VerbsCommon.Get, "ExperimentalFeature", HelpUri = "")]
[Cmdlet(VerbsCommon.Get, "ExperimentalFeature", HelpUri = "https://go.microsoft.com/fwlink/?linkid=2007351")]
Copy link
Member

@adityapatwardhan adityapatwardhan Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this by adding an entry at: https://github.com/PowerShell/PowerShell/blob/master/test/powershell/engine/Help/assets/HelpURI/V3Cmdlets.csv

Copy link
Member Author

@daxian-dbw daxian-dbw Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that test work when the URI currently points to nowhere?

Copy link
Member Author

@daxian-dbw daxian-dbw Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. csv file updated.

public class GetExperimentalFeatureCommand : PSCmdlet
{
/// <summary>
Expand Down
1 change: 1 addition & 0 deletions test/powershell/engine/Help/assets/HelpURI/V3Cmdlets.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,4 @@ ConvertFrom-Markdown,https://go.microsoft.com/fwlink/?linkid=2006503
Get-MarkdownOption,https://go.microsoft.com/fwlink/?linkid=2006371
Set-MarkdownOption,https://go.microsoft.com/fwlink/?linkid=2006265
Show-Markdown,https://go.microsoft.com/fwlink/?linkid=2006266
Get-ExperimentalFeature,https://go.microsoft.com/fwlink/?linkid=2007351