Skip to content

PathUtils: handle escaped -Path correctly #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kwkam wants to merge 2 commits into from
Closed

PathUtils: handle escaped -Path correctly #7405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae892e2
[Feature] PathUtils: handle literal -Path correctly
kwkam Jul 30, 2018
90d6f52
[Feature] Fix code format
kwkam Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/System.Management.Automation/utils/PathUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,10 @@ internal static string ResolveFilePath(string filePath, PSCmdlet command, bool i
PSDriveInfo drive = null;
path =
command.SessionState.Path.GetUnresolvedProviderPathFromPSPath(
filePath, cmdletProviderContext, out provider, out drive);
isLiteralPath ? filePath : WildcardPattern.Unescape(filePath),
cmdletProviderContext,
out provider,
out drive);
cmdletProviderContext.ThrowFirstErrorOrDoNothing();
if (!provider.NameEquals(command.Context.ProviderNames.FileSystem))
{
Expand Down
9 changes: 9 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Out-File.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Describe "Out-File" -Tags "CI" {
$expectedContent = "some test text"
$inObject = New-Object psobject -Property @{text=$expectedContent}
$testfile = Join-Path -Path $TestDrive -ChildPath outfileTest.txt
$testfileSp = Join-Path -Path $TestDrive -ChildPath "``[outfileTest``].txt"
}

AfterEach {
Expand Down Expand Up @@ -91,6 +92,14 @@ Describe "Out-File" -Tags "CI" {
$actual[11] | Should -BeNullOrEmpty
}

It "Should create the file with correct name when FilePath contains special char" {
Out-File -FilePath $testfile
Out-File -FilePath $testfileSp

$testfile | Should -Exist
$testfileSp | Should -Exist
}

It "Should limit each line to the specified number of characters when the width switch is used on objects" {

Out-File -FilePath $testfile -Width 10 -InputObject $inObject
Expand Down