Remove empty xml comment lines #7401
Conversation
iSazonov
requested review from
BrucePay,
Francisco-Gamino,
JamesWTruher,
PaulHigin,
TravisEz13,
adityapatwardhan,
anmenaga,
dantraMSFT,
daxian-dbw and
mirichmo
as code owners
| /// <summary> | ||
| /// | ||
| /// Retrieves input from the host virtual console and writes it to the pipeline output. | ||
| /// |
There was a problem hiding this comment.
The regular expression should remove this whitespace unless the line after the whitespace contains text and not <.
SteveL-MSFT
left a comment
SteveL-MSFT
left a comment
There was a problem hiding this comment.
@iSazonov I appreciate your passion to clean up the code, but perhaps we should discuss whether it's worth the review effort next time before you start a. PR as this was review took significant time.
| /// <exception cref="System.ArgumentException"> | ||
| /// path is null or empty. | ||
| /// </exception> | ||
| /// |
There was a problem hiding this comment.
Seems broken EOL.
Fixed.
| /// start the playback | ||
| /// </summary> | ||
| internal virtual void ExecuteBufferPlayBack(DoPlayBackCall playback) { } | ||
|
|
There was a problem hiding this comment.
This whitespace should probably stay
| using System.Management.Automation.Host; | ||
| using System.Management.Automation.Internal; | ||
| using Microsoft.PowerShell.Commands.Internal.Format; | ||
|
|
| /// </summary> | ||
| [Parameter(ValueFromPipeline = true)] | ||
| public PSObject InputObject { set; get; } = AutomationNull.Value; | ||
|
|
| /// True if read succeeds. | ||
| /// </returns> | ||
| /// | ||
| /// does not throw |
There was a problem hiding this comment.
Can we move this to inside the <summary/>?
|
@SteveL-MSFT We already have a tracking Issue but haven't plan. With the plan we'd freeze current PRs and spend 1-2 weeks to fix as many style issues as possible. |
iSazonov
changed the title
2 participants
PR Summary
Instead of #7356.
Please review commit by commit.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests