Skip to content

Fix Move-Item -Path with wildcard char #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Aug 5, 2018
Merged

Fix Move-Item -Path with wildcard char #7397

iSazonov merged 1 commit into from
Aug 5, 2018

Conversation

@kwkam
Copy link
Contributor

@kwkam kwkam commented Jul 29, 2018 •
edited
Loading

PR Summary

Set the context.SuppressWildcardExpansion in MoveItem instead of
escaping the path every time. Also solve the issue where Move-Item
complains -Path wildcard pattern is not valid when -Path contains
special characters that forms an invalid pattern.

PR Checklist

@kwkam
[Feature] Fix Move-Item -Path with wildcard char
8cfba44 
Unescape non-literal, non-glob path in ProccessRecord and
set the context.SuppressWildcardExpansion in RenameItem.
This solve the issue where Rename-Item complains -Path does not exist
when both -Path and CWD contains special characters.
@kwkam kwkam mentioned this pull request Jul 29, 2018
Closed
9 tasks
iSazonov
iSazonov approved these changes Jul 30, 2018
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder that we have so many try-catch blocks. Perhaps we could remove half of them ( in new PR).

@iSazonov
Copy link
Collaborator

iSazonov commented Jul 31, 2018

@mklement0 Could you please (fast) review last (~10) @kwkam 's PRs related to literal paths, wildcards and escapes?

@SteveL-MSFT Should we speed up the review of the PRs or postpone it after 6.1?

@SteveL-MSFT SteveL-MSFT requested a review from anmenaga July 31, 2018 04:55
@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Jul 31, 2018

@iSazonov other than a handful of issues marked for 6.1, if other PRs make it in that's great, if they don't we'll start shipping 6.2 Previews after 6.1 RC is out in a few weeks. Since we have stable and preview channels now, it should be ok for people to depend on stable builds and try out preview builds. Right now most of my team is focused on some other things not directly PSCore6.1 related.

@kwkam kwkam changed the title [Feature] Fix Move-Item -Path with wildcard char Fix Move-Item -Path with wildcard char Jul 31, 2018
@mklement0
Copy link
Contributor

mklement0 commented Jul 31, 2018

@iSazonov: Sorry, that's more than I can take on right now; I've glanced at this one, and it looks fine.

@iSazonov iSazonov assigned iSazonov and unassigned adityapatwardhan Aug 5, 2018
@iSazonov iSazonov merged commit fbfbb4f into PowerShell:master Aug 5, 2018
@kwkam kwkam deleted the wc-moveitem branch January 11, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@iSazonov iSazonov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kwkam @iSazonov @SteveL-MSFT @mklement0 @adityapatwardhan