Fix parameter name in the Get-Variable cmdlet error message. #7384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Jul 30, 2018
| if (scopeNumericID < 0) | ||
| { | ||
| throw PSTraceSource.NewArgumentOutOfRangeException("scopeID", scopeID); | ||
| throw PSTraceSource.NewArgumentOutOfRangeException("Scope", scopeID); |
Collaborator
There was a problem hiding this comment.
We could use "readonly const".
iSazonov
reviewed
Jul 30, 2018
|
|
||
| /// <summary> | ||
| /// Cmdlet parameter name to return in the error message | ||
| /// instead of "scopeID". |
Collaborator
There was a problem hiding this comment.
I suppose we could put it in one line - 100-120 characters is not a problem for modern displays.
iSazonov
approved these changes
Jul 30, 2018
anmenaga
approved these changes
Jul 30, 2018
Collaborator
|
@sethvs Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When using
Get-Variable(orGet-Alias) cmdlet with the -Scope parameter with wrong value, the error message refers to scopeID parameter.Even though it is the real parameter of the
GetScopeByIDandGetScopeByIDinternal methods, the error message returns to the user, who used the -Scope parameter.Fix #7383
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests