Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 25, 2018

PR Summary

Fix #7324

The PowerShellVersion fields in PSCore built-in modules were changed to 6.1 to reflect the current version of PSCore (new cmdlets were added in 6.1 timeframes). However, this breaking the scenario where a user needs to start Windows PowerShell from PSCore because the PSCore built-in modules will be found first and loaded by default, and the loading fails because they require a powershell of version 6.1.

Set PowerShellVersion to 3.0 for built-in modules to make Windows PowerShell work when starting from PSCore. This is a temporary workaround. We have the RFC PowerShell/PowerShell-RFC#133 submitted to address this issue by introducing a new environment variable representing PSModulePath for PSCore. Once we implement that RFC, this problem will go away. See #7324 (comment) for more information.

PR Checklist

… Windows PowerShell work when starting from PSCore
@daxian-dbw daxian-dbw self-assigned this Jul 25, 2018
@iSazonov
Copy link
Collaborator

I do not happy with the change and leave a comment in #7324.

@daxian-dbw
Copy link
Member Author

@iSazonov As mentioned in the PR description: This is a temporary workaround. We will revert this when the fix for the root cause is in place.

@daxian-dbw daxian-dbw merged commit 63430e9 into PowerShell:master Jul 26, 2018
@daxian-dbw daxian-dbw deleted the manifest branch July 26, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

powershell.exe started from pwsh.exe give preference to pwsh modules and fails module version compatiblity check

3 participants