-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix type catalog generation #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deprecated with new lockfile parser.
Parses PowerShell's `project.lock.json` file and emits the list of reference assemblies suitable for the type catalog generator.
This bug arose because of a shortcut previously taken when generating input for the type catalog generator. With a proper parser created, the input to the generator is now correct, and so this test should succeed.
|
@paulcallen I did this review using Reviewable in Edge. While I had to "always allow" pop-ups to let GitHub authenticate initially, it worked just fine. Edge itself got a little slow, but that's to be expected (Edge has known performance issues). Review status: 0 of 7 files reviewed at latest revision, 8 unresolved discussions. src/Microsoft.PowerShell.CoreCLR.AssemblyLoadContext/CorePsTypeCatalog.cs, line 0 [r1] (raw file): src/Microsoft.PowerShell.CoreCLR.Eventing/project.json, line 25 [r1] (raw file): src/TypeCatalogGen/build.sh, line 2 [r1] (raw file): src/TypeCatalogGen/build.sh, line 10 [r1] (raw file): src/TypeCatalogParser/Main.cs, line 17 [r1] (raw file): src/TypeCatalogParser/Main.cs, line 20 [r1] (raw file): src/TypeCatalogParser/project.json, line 1 [r1] (raw file): test/powershell/DotNetInterop.Tests.ps1, line 3 [r1] (raw file): Comments from the review on Reviewable.io |
|
Pulled, dotnet restore, and built just fine. Ran the small test you created as well and passed.
Reviewed 7 of 7 files at r1. Comments from the review on Reviewable.io |
|
Thanks, merging. Review status: all files reviewed at latest revision, 1 unresolved discussion. Comments from the review on Reviewable.io |
|
Reviewed 1 of 7 files at r1. Comments from the review on Reviewable.io |
See commits.
This change is