Skip to content

Conversation

@andyleejordan
Copy link
Member

See commits.


This change is Reviewable

Deprecated with new lockfile parser.
Parses PowerShell's `project.lock.json` file and emits the list of
reference assemblies suitable for the type catalog generator.
This bug arose because of a shortcut previously taken when generating
input for the type catalog generator. With a proper parser created, the
input to the generator is now correct, and so this test should succeed.
@andyleejordan
Copy link
Member Author

@paulcallen I did this review using Reviewable in Edge. While I had to "always allow" pop-ups to let GitHub authenticate initially, it worked just fine. Edge itself got a little slow, but that's to be expected (Edge has known performance issues).


Review status: 0 of 7 files reviewed at latest revision, 8 unresolved discussions.


src/Microsoft.PowerShell.CoreCLR.AssemblyLoadContext/CorePsTypeCatalog.cs, line 0 [r1] (raw file):
This is an auto-generated file.


src/Microsoft.PowerShell.CoreCLR.Eventing/project.json, line 25 [r1] (raw file):
These are unrelated to this PR but were necessary to quiet NuGet warnings because a prior PR was merged out-of-date.


src/TypeCatalogGen/build.sh, line 2 [r1] (raw file):
I tried to remove this remaining Mono dependency by building the generator for .NET Core. While I could get it to build successfully, it had a strange issue starting.


src/TypeCatalogGen/build.sh, line 10 [r1] (raw file):
This is hard-coded because it is the output file that the ALC expects, and the input file the generator expects.


src/TypeCatalogParser/Main.cs, line 17 [r1] (raw file):
This is hard-coded because it's what the type catalog generator is expecting.


src/TypeCatalogParser/Main.cs, line 20 [r1] (raw file):
This is hard coded because Linux.Host is our top level project, and this must be done only for the .NET Core framework.


src/TypeCatalogParser/project.json, line 1 [r1] (raw file):
I should probably add metadata here.


test/powershell/DotNetInterop.Tests.ps1, line 3 [r1] (raw file):
We should probably add more tests here eventually. I added this one in particular because it was the regression that I hit.


Comments from the review on Reviewable.io

@ealexjordan
Copy link
Contributor

:lgtm:

Pulled, dotnet restore, and built just fine. Ran the small test you created as well and passed.

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions.


Comments from the review on Reviewable.io

@andyleejordan
Copy link
Member Author

Thanks, merging.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

@ealexjordan
Copy link
Contributor

Reviewed 1 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

@andyleejordan andyleejordan merged commit d8de5d2 into master Mar 23, 2016
@andyleejordan andyleejordan deleted the typecataloggen branch March 23, 2016 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants