Add support for parsing Link Header with variable whitespace #7322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested review from
JamesWTruher,
PaulHigin,
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
TravisEz13
requested changes
Jul 20, 2018
| // we only support the URL in angle brackets and `rel`, other attributes are ignored | ||
| // user can still parse it themselves via the Headers property | ||
| string pattern = "<(?<url>.*?)>;\\srel=\"(?<rel>.*?)\""; | ||
| string pattern = "<(?<url>.*?)>;\\s*rel=\"(?<rel>.*?)\""; |
Member
There was a problem hiding this comment.
Please do not introduce any overlapping terms
Member
There was a problem hiding this comment.
Resolved, I misread the Regex
TravisEz13
approved these changes
Jul 20, 2018
markekraus
suggested changes
Jul 21, 2018
Contributor
markekraus
left a comment
markekraus
left a comment
There was a problem hiding this comment.
LGTM, but need to update WebListener documentation https://github.com/PowerShell/PowerShell/tree/master/test/tools/WebListener#link
Member
Author
|
@markekraus added documentation! |
markekraus
approved these changes
Jul 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for variable whitespace in link header
PR Summary
Thanks to the @cruscio's analysis, it appears that the Link Header allows for any amount of whitespace or even no whitespace. The currently explicitly expect a single whitespace after the semicolon in the Link Header before the
Relproperty.Fix is to change the regex to allow for variable or no whitespace and associated tests to handle these two cases. Changed
GetLinkhelper to support passing in whitespace to use.Fix #5667
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests