Fix macOS launcher app to allow release and preview versions. #7306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thezim
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
TravisEz13
reviewed
Jul 18, 2018
| Start-NativeExecution { | ||
| plutil -convert xml1 $plist | ||
| } | ||
| $plistcontent = $packagingStrings.MacOSLauncherPlistTemplate -f $packageId, $Version, $iconfilebase |
Member
There was a problem hiding this comment.
Did you forget to include this change to the strings?
Contributor
Author
There was a problem hiding this comment.
This has been corrected.
TravisEz13
approved these changes
Jul 20, 2018
Member
TravisEz13
left a comment
TravisEz13
left a comment
There was a problem hiding this comment.
restarted travis-ci due to a spelling error introduced by another change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #7074. This PR allows concurrent versions of the macOS launcher app to exist. The application name will be either
PowerShellorPowerShell-preview. It is now dynamically built and removed postfpmto avoid post build conflicts, see #5262 .PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests