Start-DevPowerShell: make it more convenient, functional #7300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More convenient: allow specifying the configuration, rather than the bin dir. More functional: don't attempt to pass null/empty ArgumentList to Start-Process.
jazzdelightsme
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
kvprasoon
suggested changes
Jul 21, 2018
build.psm1
Outdated
| [ValidateSet("Debug", "Release", "CodeCoverage", '')] # should match New-PSOptions -Configuration values | ||
| [string]$Configuration, | ||
| [Parameter(ParameterSetName='BinDirParamSet')] | ||
| [string]$binDir, |
Contributor
There was a problem hiding this comment.
I believe we follow Pascal casing for Parameters . Requesting you to change $binDir to $BinDir in Param() block and on all occurrences.
kvprasoon
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
More convenient: allow specifying the configuration, rather than the bin
dir.
More functional: don't attempt to pass null/empty ArgumentList to
Start-Process.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests