Format Utility csproj with updated codeformatter #7263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
requested review from
SteveL-MSFT,
TravisEz13,
adityapatwardhan and
daxian-dbw
iSazonov
requested review from
JamesWTruher,
PaulHigin and
dantraMSFT
as code owners
2 tasks
iSazonov
force-pushed
the
fmt-utility-csproj
branch
from
688de2b to
f91f266
Compare
11 tasks
anmenaga
approved these changes
Jul 13, 2018
SteveL-MSFT
requested changes
Jul 13, 2018
| string content = StreamToString (stream, encoding); | ||
| string content = StreamToString(stream, encoding); | ||
| if (isDefaultEncoding) do | ||
| { |
Member
There was a problem hiding this comment.
This formatting change looks odd to me. Would it be better to wrap the do..while in braces?
if (...)
{
do
{
}
while ()
}
Collaborator
Author
There was a problem hiding this comment.
CodeFormatter keeps previous formatting for if-do but remove extra braces in do-while.
So formally you ask other change - manual vs automatic formatting.
I agree that you request is right and I'll manually do the fix.
TravisEz13
approved these changes
Jul 16, 2018
Member
There was a problem hiding this comment.
Reviewed 31 of 31 files at r1.
Reviewable status:complete! all files reviewed
Approval is always assuming you address other's comments
Collaborator
Author
|
@SteveL-MSFT Your comment was addressed. |
SteveL-MSFT
approved these changes
Jul 20, 2018
TravisEz13
approved these changes
Jul 21, 2018
Member
TravisEz13
left a comment
TravisEz13
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #4708.
Format
Microsoft.PowerShell.Commands.Utility.csprojby codeformatter with default options.The codeformatter is used that I compiled with newest Roslyn packages (version 2.8.2).
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature testsThis change is