Make 'Start-PsBuild -Clean' not prompt due to locked files when Visual Studio is open by excluding sqlite3 folder and use -x instead of -X option on git clean #7235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
TravisEz13
approved these changes
Jul 5, 2018
TravisEz13
reviewed
Jul 6, 2018
build.psm1
Outdated
| # Excluded sqlite3 folder is due to this Roslyn issue: https://github.com/dotnet/roslyn/issues/23060 | ||
| git clean -fdx --exclude .vs/PowerShell/v15/Server/sqlite3 | ||
| # Extra cleaning is required to delete the CMake temporary files. | ||
| # These are not cleaned when using "X" and cause CMake to retain state, leading to |
Contributor
Author
There was a problem hiding this comment.
Should we rather remove this unchanged block (i.e. the comment and the 2nd git clean -fdx below)?
Was there a reason why the -X option was chosen initially?
Member
There was a problem hiding this comment.
Was there a reason why the -X option was chosen initially?
I'm not sure. The results of -gdx seem better to me with no unexpected effects.
adityapatwardhan
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Due to this Roslyn issue, some files in the
sqlite3folder inside the temporary.vsfolder get locked and cannot be cleaned. This happens when callingStart-PSBuild -Cleanwhen VS is open and is very annoying.This PR makes
Start-PSBuild -Cleanuse the 'better'-xoption on git clean and exclude this folder (both changes are needed to overcome the Roslyn issue).PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests