Skip to content

Adding -AllStats Switch parameter for Measure-Object cmdlet #7220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 8 commits into from
Jul 9, 2018
Merged

Adding -AllStats Switch parameter for Measure-Object cmdlet #7220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
94080b5
Adding -AllStats Switch parameter for Measure-Object cmdlet
kvprasoon Jul 1, 2018
d804ae9
Code factor fixes
kvprasoon Jul 1, 2018
bde3fe4
Code factor fix
kvprasoon Jul 1, 2018
218f5ad
Changes as per review comments.
kvprasoon Jul 2, 2018
bf55d15
Code factor fix.
kvprasoon Jul 2, 2018
1d02d79
Review comment changes
kvprasoon Jul 3, 2018
0391972
Adding assertion for StandardDeviationin unitMeasure-Object test
kvprasoon Jul 5, 2018
30a649f
Code factor issue fix.
kvprasoon Jul 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/Measure-Object.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,26 @@ public SwitchParameter Sum
}
private bool _measureSum;

/// <summary>
/// Gets or sets the value indicating if all statistics should be returned.
/// </summary>
/// <value></value>
[Parameter(ParameterSetName = GenericParameterSet)]
public SwitchParameter AllStats
{
get
{
return _allStats;
}

set
{
_allStats = value;
}
}

private bool _allStats;

/// <summary>
/// Set to true is Average is to be returned
/// </summary>
Expand Down Expand Up @@ -451,6 +471,21 @@ private bool IsMeasuringGeneric
}
}

/// <summary>
/// Does the begin part of the cmdlet.
/// </summary>
protected override void BeginProcessing()
Copy link
Contributor

@PaulHigin PaulHigin Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you should call the base class implementation, base.BeginProcessing(), here.

Copy link
Contributor Author

@kvprasoon kvprasoon Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

{
// Sets all other generic parameters to true to get all statistics.
if (_allStats)
{
_measureSum = _measureStandardDeviation = _measureAverage = _measureMax = _measureMin = true;
}

// finally call the base class.
base.BeginProcessing();
}

/// <summary>
/// Collect data about each record that comes in.
/// Side effects: Updates totalRecordCount.
Expand Down
10 changes: 10 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Measure-Object.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,16 @@ Describe "Measure-Object" -Tags "CI" {

$actual.Maximum | Should -Be $expected
}

It "Should be able to return all the statitics for given values" {
$result = 1..10 | Measure-Object -AllStats
$result.Count | Should -Be 10
$result.Average | Should -Be 5.5
$result.Sum | Should -Be 55
$result.Minimum | Should -Be 1
$result.Maximum | Should -Be 10
($result.StandardDeviation).ToString() | Should -Be '3.02765035409749'
}
}

Context "String tests" {
Expand Down