Skip to content

Fix check for vcvarsall.bat absence #7218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 1 commit into from
Jul 2, 2018
Merged

Fix check for vcvarsall.bat absence #7218

daxian-dbw merged 1 commit into from
Jul 2, 2018

Conversation

@PetSerAl
Copy link
Contributor

@PetSerAl PetSerAl commented Jul 1, 2018

PR Summary

If this line:

PowerShell/build.psm1

Line 225 in d04fef4

$vcvarsallbatPath = (Get-ChildItem $vcPath -Filter vcvarsall.bat -Recurse -File | Select-Object -First 1).FullName

does not find any candidates for vcvarsall.bat, then it ends assign $null to $vcvarsallbatPath. Passing $null for -Path parameter will cause check to fail due to parameter validation. This PR adds explicit check for $null to fix this.

PR Checklist

iSazonov
iSazonov approved these changes Jul 2, 2018
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

@daxian-dbw daxian-dbw merged commit b12dce2 into PowerShell:master Jul 2, 2018
@daxian-dbw daxian-dbw mentioned this pull request Jul 2, 2018
Closed
11 tasks
@TravisEz13
Copy link
Member

TravisEz13 commented Jul 6, 2018

@adityapatwardhan another change to port to the native repo.

@iSazonov iSazonov mentioned this pull request Jul 6, 2018
Closed
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 6, 2018

I suggest cut off and do changes only in https://github.com/PowerShell/PowerShell-Native

@iSazonov iSazonov mentioned this pull request Jul 6, 2018
Merged
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jul 9, 2018

I agree, I will update the README file under libpsl-native and powershell-native folder accordingly.

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jul 9, 2018

Opened a PR for the README updates. #7248

@PetSerAl PetSerAl deleted the vcvarsall-check branch August 22, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PetSerAl @TravisEz13 @iSazonov @adityapatwardhan @daxian-dbw