Update building guide's output folder to netcoreapp2.1 #7205
Conversation
|
@louistio Thanks for the contribution. It would be great if you can also update the Linux and macOS docs. |
|
|
adamgauthier
changed the title
|
@daxian-dbw Hey, I added a new commit for the Linux path. I would normally amend my first commit and change the message not to be windows-specific, but I see in the contributing guide that you guys don't like rewriting history, how should I proceed? |
|
@louistio Just push new commits to your remote branch and update the PR description to reflect the changes. Don't worry about the message in each commit, we will squash the commits when merging the PR. I have verified that on macOS, it's |
|
@daxian-dbw Alright, thanks. I just changed it for macOS too (also I removed that line mentioning the executable being under a |
|
Your changes look good. Thank you! |
|
Travis CI completes successfully (see here), but the status report stuck. |
3 participants
PR Summary
This fixes the building guide for windows, linux and macOS in
Powershell/docs/building/to reflect the actual default output folder when following the instructions. They lead to the executable being created under./src/[platform]/bin/Debug/netcoreapp2.1/..., not./src/[platform]/bin/Debug/netcoreapp2.0/....PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature testsThis should probably be done in the linux and macOS building guides, but I can't verify it for sure since I have a windows machine, let me know if this is the case and I can add an additional commit for them.