Adding ability to install previews side-by-side with production releases #7194
Conversation
-preview switch: - installs pwsh-preview packages when a package manager is being used. - uses link name pwsh-preview when tar ball install is being done - results in preview release being available for calling manually, but does not become systemwide version
DarwinJS
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
| * -includeide - installs vscode and vscode powershell extension (only relevant to machines with desktop environment) | ||
| * -interactivetesting - do a quick launch test of vscode - only relevant when used with -includeide | ||
| * -skip-sudo-check - use sudo without verifying it's availability (hard to accurately do on some distros) | ||
| * -allowprerelease - includes prereleases of powershell core when selection allows this. Repository based installs take the latest on the repo url regardless of this switch. |
There was a problem hiding this comment.
technically, this is a breaking change, but not in the product
There was a problem hiding this comment.
I think it is fine since it hasn't been in for long
There was a problem hiding this comment.
Yeah, I think it was only working for 24-36 hours. But the "allow" made it sound like they wouldn't be isolated, parallel installs, but possibly install over production.
There was a problem hiding this comment.
Agreed, this lgtm, but I'm supposed to give 24 hours for review.
There was a problem hiding this comment.
Also these changes are just trying to keep up with significant "breaking change" design decisions - like establishing the entirely separate package id for previews. It's a great change - but such shifts are the lions share of "breaking" compared to the breaking code changes needed to support them.
2 participants
PR Summary
-preview switch:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests