Skip to content

Add test to verify filesystem provider isn't used when accessing root path in psdrive #7173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 2 commits into from
Jul 11, 2018
Merged

Add test to verify filesystem provider isn't used when accessing root path in psdrive #7173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17a735d
add test to verify filesystem isn't used when not in filesystem drive
Jun 25, 2018
ef948e3
address Bruce's feedback
SteveL-MSFT Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Set-Location.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,22 @@ Describe "Set-Location" -Tags "CI" {
$(Get-Location).Path | Should -BeExactly $testPath.FullName
}

It "Should not use filesystem root folder if not in filesystem provider" -Skip:(!$IsWindows) {
# find filesystem root folder that doesn't exist in HKCU:
$foundFolder = $false
foreach ($folder in Get-ChildItem "${env:SystemDrive}\" -Directory) {
if (-Not (Test-Path "HKCU:\$($folder.Name)")) {
$testFolder = $folder.Name
$foundFolder = $true
break
}
}
$foundFolder | Should -BeTrue
Set-Location HKCU:\
Copy link
Member

@adityapatwardhan adityapatwardhan Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Push-Location HKCU:\ in try and Pop-Location in finally to reset the current working directory.

Copy link
Member Author

@SteveL-MSFT SteveL-MSFT Jun 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for Set-Location tests, though. There's a BeforeAll and AfterAll that sets the location back to where it was.

Copy link
Member

@adityapatwardhan adityapatwardhan Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. closed.

{ Set-Location ([System.IO.Path]::DirectorySeparatorChar + $testFolder) -ErrorAction Stop } |
Should -Throw -ErrorId "PathNotFound,Microsoft.PowerShell.Commands.SetLocationCommand"
}

Context 'Set-Location with no arguments' {

It 'Should go to $env:HOME when Set-Location run with no arguments from FileSystem provider' {
Expand Down