Skip to content

Move to dotnet 2.1.301 #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 8 commits into from
Jun 29, 2018
Merged

Move to dotnet 2.1.301 #7161

daxian-dbw merged 8 commits into from
Jun 29, 2018

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Jun 25, 2018 •
edited
Loading

PR Summary

Move to latest dotnet version - 2.1.301
Log dotnet --info
Add RuntimeFrameworkVersion 2.1.1

PR Checklist

@iSazonov iSazonov requested a review from SteveL-MSFT June 25, 2018 07:43
@iSazonov
Copy link
Collaborator Author

iSazonov commented Jun 25, 2018

@markekraus Could you please look the issue with WebListener on Ci Appveyor?

@markekraus
Copy link
Contributor

markekraus commented Jun 25, 2018

@iSazonov I must be missing something... don't see any weblistener issues. I do see an issue with Files.wxs and I see an issue with accessing nuget repos.. but that doesn't have anything to do with web listener as far as I can tell.

Don't you also need to add <RuntimeFrameworkVersion>2.1.1</RuntimeFrameworkVersion> to the test/Test.Common.props file?

You might even need version bumps in test/tools/WebListener/WebListener.csproj?

@iSazonov
Copy link
Collaborator Author

iSazonov commented Jun 25, 2018

@markekraus I meat

Restoring packages for C:\projects\powershell\test\tools\WebListener\WebListener.csproj...
 99  Restoring packages for C:\projects\powershell\test\tools\WebListener\WebListener.csproj...
 100  Retrying 'FindPackagesByIdAsync' for source 'https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.httpoverrides/index.json'.
 101  The HTTP request to 'GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.httpoverrides/index.json' has timed out after 100000ms.
 102  Retrying 'FindPackagesByIdAsync' for source 'https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.mvc.abstractions/index.json'.
 103  The HTTP request to 'GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/microsoft.aspnetcore.mvc.abstractions/index.json' has timed out after 100000ms.
 104  Retrying 'FindPackagesByIdAsync' for source 'https://powershell.myget.org/F/powershell

@markekraus
Copy link
Contributor

markekraus commented Jun 25, 2018

@iSazonov those are nuget errors.. not issues with WebListener. Could be network issue in AppVeyor. or anything between AppVeyor and the various nuget feeds it is timing out on.

SteveL-MSFT
SteveL-MSFT requested changes Jun 25, 2018
View reviewed changes
assets/files.wxs Outdated
</Component>
<Component Id="cmp8777CA81FBD5C5FAC86993893043793D" Guid="{B2D9982B-D46A-4D69-AA16-CC7EC49D357F}">
<File Id="fil9A6CE1B34698E9E81BC367B9E9CEBF25" KeyPath="yes" Source="$(env.ProductSourcePath)\sos_$(var.FileArchitecture)_$(var.FileArchitecture)_4.6.26515.07.dll" />
- <Component Id="cmp94bba02944344967a5b4abedb5e5ad21" Guid="{0e836bc9-94c6-42f2-b213-2990d06172be}">
Copy link
Member

@SteveL-MSFT SteveL-MSFT Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to update the GUIDs/IDs. Not sure, but the wix error might be expecting GUIDs to be all uppercase?

Copy link
Member

@TravisEz13 TravisEz13 Jun 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file name changed, you should change either the Id or the GUID. Any patching scenario would require it and we should always assume we will be required to patch even previews.

Copy link
Collaborator Author

@iSazonov iSazonov Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I fix only case or something else?

Copy link
Member

@TravisEz13 TravisEz13 Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that the case is what you need to fix. The error is not very useful when compared to the change.

@anmenaga
Copy link

anmenaga commented Jun 25, 2018

Is there patch notes for version 301 ?

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Jun 25, 2018

@anmenaga Release notes are here https://github.com/dotnet/core/blob/master/release-notes/2.1/2.1.1.md

daxian-dbw
daxian-dbw reviewed Jun 26, 2018
View reviewed changes
build.psm1 Outdated
$env:PATH = $originalPath
} else {
$dotnetInfo = (dotnet --info)
Write-Log "dotnet --info: `n$dotnetInfo"
Copy link
Member

@daxian-dbw daxian-dbw Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dontet --info would be too verbose I think. How about just use "dotnet --version"?

Copy link
Collaborator Author

@iSazonov iSazonov Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really this is needed only for moving to new .Net Core versions. I think we could remove the logging at all. dotnet --version is not so useful because don't show versions of all components.

Copy link
Member

@daxian-dbw daxian-dbw Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing sounds good to me.

@daxian-dbw
Copy link
Member

daxian-dbw commented Jun 26, 2018

@iSazonov With 2.1.1, can you please verify if the fix about File.Attributes on the special operating system files (hiberfil.sys, pagefile.sys and swapfile.sys) are working properly? This is regarding our discussions at #6929 (comment)

@anmenaga
Copy link

anmenaga commented Jun 26, 2018

From where were the updated package version numbers taken from? e.g:
<PackageReference Include="System.ServiceModel.Primitives" Version="4.5.1" />
Can you please help me understand the link how a new package number like example above was associated with new dotnet version?

@iSazonov
Copy link
Collaborator Author

iSazonov commented Jun 27, 2018

@anmenaga I don't know package numbering schema. Seems 4.4.x is for .Net Core 2.0 and 4.5.x for 2.1.
We use Get-NewOfficalPackage from our tools\releaseTools.psm1 to check packages versions.

@iSazonov
Copy link
Collaborator Author

iSazonov commented Jun 27, 2018 •
edited
Loading

@daxian-dbw Yes, we got the fix in 2.1.1 - I checked on CI artifact builds from the both PRs.

daxian-dbw
daxian-dbw approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov I have removed the logging code in build.psm1.

@daxian-dbw daxian-dbw merged commit 839ecb8 into PowerShell:master Jun 29, 2018
@iSazonov iSazonov deleted the move-to-2.1.301 branch June 29, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@daxian-dbw daxian-dbw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iSazonov @markekraus @anmenaga @SteveL-MSFT @daxian-dbw @TravisEz13