Add tests for module specifications #7140
Conversation
rjmholt
added
WG-Engine
| # Take a base hashtable and produce all possible | ||
| # combinations of that hashtable with the keys | ||
| # and values in the key/value hashtable | ||
| function PermuteHashtable |
There was a problem hiding this comment.
Can the test structures be initialized statically? It seems to be more simple and visual than to understand this helper code. What do you think?
There was a problem hiding this comment.
I've been thinking about this. You're definitely right that the number of possible ModuleSpecification field combinations is lower than I imagined initially.
On the other hand, for every field that could be added to a ModuleSpecification, we would have to generate exponentially more tests vs add a single field in here. Perhaps that's unlikely. But I can see something like PSEdition being added, which would take the number of static cases from 6 to 12.
| foreach ($ht in $Hashtable) | ||
| { | ||
| $ht.Clone() | ||
| } |
There was a problem hiding this comment.
Just as an aside doing @{} + $ht is essentially equivalent to .Clone()
There was a problem hiding this comment.
Aha! Which do you consider nicer (for our purposes)?
|
|
||
| BeforeAll { | ||
| $modSpecAsm = [Microsoft.PowerShell.Commands.ModuleSpecification].Assembly | ||
| $modSpecComparerType = $modSpecAsm.GetType("Microsoft.PowerShell.Commands.ModuleSpecificationComparer") |
There was a problem hiding this comment.
You could use using namespace to get rid of the long type names.
|
@adityapatwardhan Seems the PR is ready to merge. |
4 participants
PR Summary
Testing to validate #7126. (This should be merged first)
Adds testing specifically for all the code around ModuleSpecification objects. In particular:
ToString()funtionality (paired with parsing back to the object)PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests