Skip to content

Updates to build for Alpine #7139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
Jun 25, 2018
Merged

Updates to build for Alpine #7139

TravisEz13 merged 2 commits into from
Jun 25, 2018

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jun 22, 2018 •
edited
Loading

PR Summary

setdate.cpp was incorrectly assigning an int to a struct, fixed to initialize struct zero'd
update the typegen project in the bash script
added some help text at top of script for someone trying to build it
updated runtime to linux-musl-x64 instead of linux-x64 as Alpine distro uses the musl libc libraries instead of glibc which is used by most distros.

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from TravisEz13 June 22, 2018 01:13
iSazonov
iSazonov reviewed Jun 22, 2018
View reviewed changes
src/libpsl-native/src/setdate.cpp Outdated
Copy link
Collaborator

@iSazonov iSazonov Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should migrate to stime #6962

Copy link
Member Author

@SteveL-MSFT SteveL-MSFT Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we eventually move to a dotnet api, I don't think it's worth the effort to change to stime now. I need this change as the native build portion for Alpine fails here.

dantraMSFT
dantraMSFT approved these changes Jun 22, 2018
View reviewed changes
tools/releaseBuild/Images/microsoft_powershell_alpine3/build-and-run-pwsh.sh Outdated
Copy link
Contributor

@dantraMSFT dantraMSFT Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Are the white space diffs really needed?

Copy link
Member Author

@SteveL-MSFT SteveL-MSFT Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent 4 spaces indentation (was copied from build.psm1)

@SteveL-MSFT SteveL-MSFT mentioned this pull request Jun 22, 2018
Merged
11 tasks
@TravisEz13
Copy link
Member

TravisEz13 commented Jun 25, 2018

The intent for alpine is to always have a separate alpine build?

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jun 25, 2018

Filed issue to figure out Alpine Linux release #7167

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jun 25, 2018

I think it's fine to have just an Alpine docker image w/ PSCore6

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jun 25, 2018

I should change the runtime to linux-musl-x64 to match the packaging

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jun 25, 2018

Note that for dotnet, alpine-x64 == linux-musl-x64, however the nuget pkg that contains crossgen has it under the linux-musl-x64 file path, so using that one.

@TravisEz13 TravisEz13 merged commit 7d72e38 into PowerShell:master Jun 25, 2018
@SteveL-MSFT SteveL-MSFT deleted the alpine-linux branch June 25, 2018 23:36
daxian-dbw added a commit that referenced this pull request Jun 26, 2018
@daxian-dbw
Revert "Updates to build for Alpine (#7139)"
1a55c33 
This reverts commit 7d72e38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+1 more reviewer

@dantraMSFT dantraMSFT dantraMSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SteveL-MSFT @TravisEz13 @adityapatwardhan @dantraMSFT @iSazonov