Skip to content

Remove PSReadLine from Solution (sln) file #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Jun 22, 2018
Merged

Remove PSReadLine from Solution (sln) file #7137

iSazonov merged 2 commits into from
Jun 22, 2018

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jun 21, 2018 •
edited
Loading

PR Summary

When I removed the PSReadLine source code to use the PSGallery version, I did not remove the PSReadLine project from the Visual Studio .sln file which is not longer valid as the source doesn't exist here.

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from iSazonov June 21, 2018 21:52
@daxian-dbw
Copy link
Member

daxian-dbw commented Jun 21, 2018

Microsoft.PowerShell.PSReadLine also shows up in tests, test assets, and OpenCover module. I think those can be addressed in a separate PR.

PS:43> dir * -Recurse | sls -SimpleMatch 'Microsoft.PowerShell.PSReadLine' | % Path | sort -Unique
F:\PowerShell\.spelling
F:\PowerShell\assets\files.wxs
F:\PowerShell\docs\testing-guidelines\CodeCoverageAnalysis.md
F:\PowerShell\test\powershell\engine\Help\assets\PSReadline_5714753b-2afd-4492-a5fd-01d9e2cff8b5_en-US_helpcontent.cab
F:\PowerShell\test\powershell\engine\Help\assets\PSReadline_5714753b-2afd-4492-a5fd-01d9e2cff8b5_en-US_helpcontent.zip
F:\PowerShell\test\powershell\engine\Help\HelpSystem.Tests.ps1
F:\PowerShell\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1
F:\PowerShell\test\tools\OpenCover\OpenCover.psm1

daxian-dbw
daxian-dbw approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov
Copy link
Collaborator

iSazonov commented Jun 22, 2018

@SteveL-MSFT Do you plan continue or we can merge?

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jun 22, 2018

@iSazonov We can do the broader changes in a separate PR. I need this change as it affects building for Alpine.

@iSazonov iSazonov merged commit 4ad56b3 into PowerShell:master Jun 22, 2018
@SteveL-MSFT SteveL-MSFT deleted the remove-psreadline-sln branch June 22, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov Awaiting requested review from iSazonov

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@iSazonov iSazonov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SteveL-MSFT @daxian-dbw @iSazonov