Skip to content

Modify the -AsHashTable code to get the base object from the PSObject for the hashtable. #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jun 28, 2018
Merged

Modify the -AsHashTable code to get the base object from the PSObject for the hashtable. #7123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/group-object.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ protected override void EndProcessing()
{
if (_grp.Values.Count == 1)
{
_table.Add(_grp.Values[0], _grp.Group);
_table.Add(PSObject.Base(_grp.Values[0]), _grp.Group);
Copy link
Contributor

@dantraMSFT dantraMSFT Jun 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest leaving a comment here since the change is rather subtle; otherwise, the change looks good to me.

Copy link
Collaborator

@iSazonov iSazonov Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the comment would be useful.

}
else
{
Expand Down
18 changes: 18 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Group-Object.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,24 @@ Describe "Group-Object" -Tags "CI" {
It "Should not throw error when using AsString when the AsHashTable was added" {
{ $testObject | Group-Object -AsHashTable -AsString } | Should -Not -Throw
}

It "Should be able to retrieve objects by key when using -AsHashTable without -AsString" {
$testObject = [pscustomobject] @{a="one"; b=2}, [pscustomobject] @{a="two"; b=10}
$result = $testObject | Group-Object -AsHashtable -Property a
$result.one.b | Should -Be 2
$result["two"].b | Should -Be 10
}

It "User's scenario should work (see issue #6933 for link to stackoverflow question)" {
# Sort numbers into two groups even succeeded, odd failed.
$result = 1..9 | foreach {[PSCustomObject]@{ErrorMessage = if ($_ % 2) {'SomeError'} else {''}}} |
Group-Object -Property {if ($_.ErrorMessage) {'Failed'} else {'Successful'}} -AsHashTable

$result['Failed'].ErrorMessage.Count | Should -Be 5
$result['Failed'].ErrorMessage[0] | Should -Be 'SomeError'
$result['Successful'].ErrorMessage.Count | Should -Be 4
$result['Successful'].ErrorMessage[0] | Should -Be ''
Copy link
Collaborator

@iSazonov iSazonov Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use more readable value instead of ''?

}
}

Describe "Check 'Culture' parameter in order object cmdlets (Group-Object, Sort-Object, Compare-Object)" -Tags "CI" {
Expand Down