Modify the -AsHashTable code to get the base object from the PSObject for the hashtable. #7123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct when creating a key in the hashtable.
BrucePay
requested review from
JamesWTruher,
PaulHigin and
dantraMSFT
as code owners
dantraMSFT
approved these changes
Jun 21, 2018
| if (_grp.Values.Count == 1) | ||
| { | ||
| _table.Add(_grp.Values[0], _grp.Group); | ||
| _table.Add(PSObject.Base(_grp.Values[0]), _grp.Group); |
Contributor
There was a problem hiding this comment.
I suggest leaving a comment here since the change is rather subtle; otherwise, the change looks good to me.
Collaborator
There was a problem hiding this comment.
Yes, the comment would be useful.
iSazonov
reviewed
Jun 22, 2018
| $result['Failed'].ErrorMessage.Count | Should -Be 5 | ||
| $result['Failed'].ErrorMessage[0] | Should -Be 'SomeError' | ||
| $result['Successful'].ErrorMessage.Count | Should -Be 4 | ||
| $result['Successful'].ErrorMessage[0] | Should -Be '' |
Collaborator
There was a problem hiding this comment.
Can we use more readable value instead of ''?
Collaborator
|
@BrucePay Thanks for this! I've wanted to use it several times but always ended up being frustrated. |
iSazonov
changed the title
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #6933.
Modified the
Group-Object -AsHashTablecode to get the base object from the PSObject before using the value to create a key in the hashtable.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests