Skip to content

Make Native globbing on UNIX return an absolute path when it is given an absolute path #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Aug 7, 2018
Merged

Make Native globbing on UNIX return an absolute path when it is given an absolute path #7106

TravisEz13 merged 1 commit into from
Aug 7, 2018

Conversation

@BrucePay
Copy link
Collaborator

@BrucePay BrucePay commented Jun 18, 2018 •
edited by iSazonov
Loading

PR Summary

Fix #7089. Native globbing on UNIX was turning absolute paths into relative paths when it shouldn't. The code suppresses generating a relative path for paths starting with '~'. It also need to do the same for paths starting with '/'.

PR Checklist

Fix for PowerShell#7089. Native globbing on UNIX was turning absolute…
eede66c 
… paths into relative paths when it shouldn't
@BrucePay BrucePay requested a review from daxian-dbw as a code owner June 18, 2018 23:43
@TravisEz13 TravisEz13 changed the title Fix for #7089. Native globbing on UNIX was turning absolute paths into relative paths when it shouldn't Native globbing on UNIX was turning absolute paths into relative paths when it shouldn't Jun 19, 2018
@TravisEz13 TravisEz13 changed the title Native globbing on UNIX was turning absolute paths into relative paths when it shouldn't Make Native globbing on UNIX was return absolute path when it is given an absolute path Jun 19, 2018
@BrucePay BrucePay changed the title Make Native globbing on UNIX was return absolute path when it is given an absolute path Make Native globbing on UNIX return an absolute path when it is given an absolute path Jun 19, 2018
@BrucePay BrucePay changed the title Make Native globbing on UNIX return an absolute path when it is given an absolute path Fix for #7089. Make Native globbing on UNIX return an absolute path when it is given an absolute path Jun 28, 2018
@stale
Copy link

stale bot commented Jul 28, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Jul 28, 2018
@iSazonov iSazonov changed the title Fix for #7089. Make Native globbing on UNIX return an absolute path when it is given an absolute path Make Native globbing on UNIX return an absolute path when it is given an absolute path Jul 30, 2018
@stale stale bot removed the Stale label Jul 30, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Jul 30, 2018

@daxian-dbw Can you review?

anmenaga
anmenaga approved these changes Aug 2, 2018
View reviewed changes
Copy link

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13 TravisEz13 merged commit 0c11582 into PowerShell:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

+1 more reviewer

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrucePay @TravisEz13 @daxian-dbw @anmenaga