Only display properties with values for MeasureInfo #7104

powercode · 2018-06-18T21:26:55Z

PR Summary

Adding Item selection conditions to the list formatting info for MeasureInfo so that only the properties with values gets displayed

Reopening #6214

PR Checklist

This change is

…ition

iSazonov · 2018-06-19T03:47:56Z

From #6412 #6214 (comment)

@PowerShell/powershell-committeeTeam members are private reviewed this and is ok with the public apis

powercode · 2018-07-04T12:35:57Z

The build errors seems completely separate from my changes.
@iSazonov Can you restart the build?

iSazonov · 2018-07-04T13:31:59Z

Reopen the PR to restart CIs.

powercode · 2018-07-04T14:38:13Z

I don't intend to fix the remaining CodeFactor issues.

anmenaga · 2018-07-13T19:05:44Z

@JamesWTruher can you please take a look? Thx.

anmenaga · 2018-08-02T21:05:07Z

Jim is on a leave; + @SteveL-MSFT for review who is familiar with formatting APIs.

SteveL-MSFT · 2018-08-09T01:08:32Z

....Management.Automation/FormatAndOutput/common/DisplayDatabase/displayDescriptionData_List.cs

        }

-        private ListEntryBuilder AddItem(string value, string label, DisplayEntryValueType kind, string format)
+        private ListEntryBuilder AddItem(string value, string label, DisplayEntryValueType kind, string format, DisplayEntry itemSelectionContition)


typo: itemSelectionCondition

SteveL-MSFT · 2018-08-09T01:08:50Z

....Management.Automation/FormatAndOutput/common/DisplayDatabase/displayDescriptionData_List.cs


        /// <summary></summary>
-        public ListEntryBuilder AddItemScriptBlock(string scriptBlock, string label = null, string format = null)
+        public ListEntryBuilder AddItemScriptBlock(string scriptBlock, string label = null, string format = null, DisplayEntry itemSelectionContition = null)


typo: itemSelectionCondition

SteveL-MSFT · 2018-08-09T01:09:04Z

....Management.Automation/FormatAndOutput/common/DisplayDatabase/displayDescriptionData_List.cs


        /// <summary></summary>
-        public ListEntryBuilder AddItemProperty(string property, string label = null, string format = null)
+        public ListEntryBuilder AddItemProperty(string property, string label = null, string format = null, DisplayEntry itemSelectionContition = null)


typo: itemSelectionCondition

SteveL-MSFT · 2018-08-09T01:09:19Z

....Management.Automation/FormatAndOutput/common/DisplayDatabase/displayDescriptionData_List.cs

+        /// <summary></summary>
+        public ListEntryBuilder AddItemPropertyIfSet(string property, string label = null, string format = null)
+        {
+            var itemSelectionContition = DisplayEntry.CreatePropertyEntry(property);


typo: itemSelectionCondition

SteveL-MSFT

LGTM

iSazonov · 2018-08-17T04:02:52Z

test/powershell/Modules/Microsoft.PowerShell.Utility/object.tests.ps1

+            $text = 1, 2, 3 | Measure-Object -Minimum -Maximum | Format-List | Out-String
+            $text -match "min" | Should -BeTrue
+            $text -match "max" | Should -BeTrue
+            $text -match 'Average' | Should -BeFalse


Seems we skipped

$text -match 'Sum' | Should -BeFalse

@powercode Please address the comment.

iSazonov · 2018-08-27T07:08:55Z

@BrucePay @lzybkr Please look the PR.

iSazonov · 2018-08-28T03:20:40Z

@powercode Thank you for the contribution!

I added "Documentation-Needed" label (if you can please open new issue in PowerShell-Docs repo).

lzybkr · 2018-08-28T04:03:35Z

...ystem.Management.Automation/FormatAndOutput/common/DisplayDatabase/displayDescriptionData.cs

+        /// <returns>A <see cref="DisplayEntry"/> for the <paramref name="scriptblock"/>.</returns>
+        public static DisplayEntry CreateScriptBlockEntry(string scriptblock)
+        {
+            return new DisplayEntry(scriptblock, DisplayEntryValueType.ScriptBlock);


@PaulHigin should review this new public api for any security implications in creating script blocks that might circumvent the language mode.

@PaulHigin reviewed this and told me he doesn't see a security issue. @PaulHigin can you confirm?

SteveL-MSFT · 2018-09-10T18:26:07Z

@iSazonov we should revert this commit until security review of the public api has been completed

cc @TravisEz13

…ll#7104)" This reverts commit 87ccd0a until security review of the public api has been completed.

iSazonov · 2018-09-11T03:26:28Z

@SteveL-MSFT Opened #7754.

…7754) This reverts commit 87ccd0a until security review of the public api has been completed.

…ll#7104)" (PowerShell#7754) This reverts commit 87ccd0a until security review of the public api has been completed.

Staffan Gustafsson and others added 6 commits June 18, 2018 23:11

Adding support for built-in List formats to include ItemSelectionCond…

8131fa1

…ition

Adding ItemSelectionCondition to GenericMeasureInfo

7906048

Adding tests for MeasureInfo format-list

bee583e

Addressing review comments

356faf9

fixing casing of Sum

f069ac4

Adding positive tests

2bb06fe

iSazonov added the Committee-Reviewed PS-Committee has reviewed this and made a decision label Jun 19, 2018

iSazonov requested review from JamesWTruher and lzybkr June 19, 2018 03:49

iSazonov self-assigned this Jun 19, 2018

iSazonov closed this Jul 4, 2018

iSazonov reopened this Jul 4, 2018

anmenaga requested a review from SteveL-MSFT August 2, 2018 21:02

SteveL-MSFT requested changes Aug 9, 2018

View reviewed changes

powercode added 3 commits August 9, 2018 20:56

Fixing typo

42b4a68

Code factor fixes.

f6ffe1a

Yet another code factor.

f6d6633

SteveL-MSFT approved these changes Aug 16, 2018

View reviewed changes

SteveL-MSFT requested a review from BrucePay August 16, 2018 18:23

iSazonov reviewed Aug 17, 2018

View reviewed changes

Adding missing testcase for Sum.

b424329

powercode force-pushed the formatting_ItemSelectionConditions branch from 1b4a460 to b424329 Compare August 27, 2018 19:45

iSazonov changed the title ~~MeasureInfo: Only display properties with values~~ Only display properties with values for MeasureInfo Aug 28, 2018

iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Aug 28, 2018

iSazonov merged commit 87ccd0a into PowerShell:master Aug 28, 2018

lzybkr reviewed Aug 28, 2018

View reviewed changes

powercode mentioned this pull request Aug 28, 2018

Document ListEntryBuilder.AddItemScriptBlock with itemSelectionCondition MicrosoftDocs/PowerShell-Docs#2862

Closed

8 tasks

TravisEz13 mentioned this pull request Aug 28, 2018

Review change per PR comment post merge #7652

Closed

iSazonov added a commit to iSazonov/PowerShell that referenced this pull request Sep 11, 2018

Revert "Only display properties with values for MeasureInfo (PowerShe…

65babca

…ll#7104)" This reverts commit 87ccd0a until security review of the public api has been completed.

iSazonov mentioned this pull request Sep 11, 2018

Revert "Only display properties with values for MeasureInfo (#7104)" #7754

Merged

11 tasks

TravisEz13 pushed a commit that referenced this pull request Oct 11, 2018

Revert "Only display properties with values for MeasureInfo (#7104)" (#…

17fd2e9

…7754) This reverts commit 87ccd0a until security review of the public api has been completed.

joeyaiello mentioned this pull request Oct 15, 2018

Docs needed for 'Only display properties with values for MeasureInfo' MicrosoftDocs/PowerShell-Docs#3032

Closed

joeyaiello removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018

This was referenced May 24, 2019

Review PR to only show MeasureInfo with populated values for security concerns #9726

Closed

Test-Connection Changes PowerShell/PowerShell-RFC#172

Merged

Only display properties with values for MeasureInfo #7104

Only display properties with values for MeasureInfo #7104

Uh oh!

Conversation

powercode commented Jun 18, 2018 • edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

iSazonov commented Jun 19, 2018

Uh oh!

powercode commented Jul 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Jul 4, 2018

Uh oh!

powercode commented Jul 4, 2018

Uh oh!

anmenaga commented Jul 13, 2018

Uh oh!

anmenaga commented Aug 2, 2018

Uh oh!

SteveL-MSFT Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT Aug 9, 2018

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

iSazonov Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

iSazonov commented Aug 27, 2018

Uh oh!

iSazonov commented Aug 28, 2018

Uh oh!

lzybkr Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT Jun 10, 2019

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT commented Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Sep 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

powercode commented Jun 18, 2018 •

edited by iSazonov

Loading

powercode commented Jul 4, 2018 •

edited

Loading

iSazonov Aug 17, 2018 •

edited

Loading

SteveL-MSFT commented Sep 10, 2018 •

edited

Loading