Comment about dynamic members for the DotNetAdapter 'GetMember' and 'GetMembers' #7087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
DotNetAdapter.GetMembers<T>(object obj)returns dynamic members for an object that implementsIDynamicMetaObjectProvider, however,DotNetAdapter.GetMember<T>(object obj, string memberName)doesn't include dynamic members. I believe this makes sense and thus update the comment to clarify it in the code.Be noted that,
GetMember<T>(object obj, string memberName)doesn't returnEventmembers either, whileGetMembers<T>(object obj)does.Background
The question about this was raised in #6898 (comment). After investigation, I found it's because
DotNetAdapter.GetMember<T>(object obj, string memberName)doesn't return dynamic members, and thus submit this PR to call it out in the code comments.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests