-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add 'CompatiblePSEditions' to PowerShell Core built-in modules #7083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do we control the PSReadLine psd1? I noticed trying it with my compatibility checking prototype that it also doesn't have this field 😱 |
| Author="PowerShell" | ||
| CompanyName="Microsoft Corporation" | ||
| Copyright="Copyright (c) Microsoft Corporation. All rights reserved." | ||
| ModuleVersion="3.0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a request to update our in-package ModuleVersion #2136, I think we can just have the ModuleVersion match the PSCore version "6.1.0.0" for this release until we can actually decouple them.
|
@rjmholt That needs to be addressed in the PSReadLine repo. However, since PSReadLine supports PSv3 and higher which doesn't understand the |
|
Also, given that the modules have been changing in sync with PowerShell and that PowerShell is now version 6.1, should the It's unlikely that someone would even manage to get to the point where loading old PowerShell modules into a newer version is possible, but it's conceivable, and in principle should be protected against maybe? |
|
@SteveL-MSFT New PSReadLine will only support v5+ right? So that can have the field? But I'm assuming that until then, or in cases using older PSReadLine versions, we take advantage of implicit compatibility due to path location? |
|
@rjmholt regarding |
|
@rjmholt @SteveL-MSFT Your comments were addressed, please take another look when you have time. Thanks! |
|
@SteveL-MSFT Looks like PSReadLine 2.0 is now v5+: https://github.com/lzybkr/PSReadLine/blob/46960b1fe442024923381eedd1c9100ded30d123/PSReadLine/Changes.txt#L32 I'll open an issue to update the PSD1 |
PR Summary
Add
CompatiblePSEditions = @("Core")to PowerShell Core built-in modules.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests