Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jun 15, 2018

PR Summary

Add CompatiblePSEditions = @("Core") to PowerShell Core built-in modules.

PR Checklist

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 15, 2018

Do we control the PSReadLine psd1? I noticed trying it with my compatibility checking prototype that it also doesn't have this field 😱

Author="PowerShell"
CompanyName="Microsoft Corporation"
Copyright="Copyright (c) Microsoft Corporation. All rights reserved."
ModuleVersion="3.0.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a request to update our in-package ModuleVersion #2136, I think we can just have the ModuleVersion match the PSCore version "6.1.0.0" for this release until we can actually decouple them.

@SteveL-MSFT
Copy link
Member

@rjmholt That needs to be addressed in the PSReadLine repo. However, since PSReadLine supports PSv3 and higher which doesn't understand the CompatiblePSEditions property, we can't add it.

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 15, 2018

Also, given that the modules have been changing in sync with PowerShell and that PowerShell is now version 6.1, should the PowerShellVersion field be 6.1?

It's unlikely that someone would even manage to get to the point where loading old PowerShell modules into a newer version is possible, but it's conceivable, and in principle should be protected against maybe?

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 15, 2018

@SteveL-MSFT New PSReadLine will only support v5+ right? So that can have the field? But I'm assuming that until then, or in cases using older PSReadLine versions, we take advantage of implicit compatibility due to path location?

@SteveL-MSFT
Copy link
Member

@rjmholt regarding PowerShellVersion, yes it would be more accurate to set it to 6.1. As for PSReadLine, I think even 2.0.0 still supports v3, not sure. I would suggest following up on the PSReadLine repo.

@daxian-dbw
Copy link
Member Author

@rjmholt @SteveL-MSFT Your comments were addressed, please take another look when you have time. Thanks!

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 15, 2018

@SteveL-MSFT Looks like PSReadLine 2.0 is now v5+: https://github.com/lzybkr/PSReadLine/blob/46960b1fe442024923381eedd1c9100ded30d123/PSReadLine/Changes.txt#L32

I'll open an issue to update the PSD1

@daxian-dbw daxian-dbw merged commit 00b0af1 into PowerShell:master Jun 15, 2018
@daxian-dbw daxian-dbw deleted the manifests branch June 15, 2018 22:29
daxian-dbw added a commit that referenced this pull request Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants