Remove unneeded "Windows-Full" modules #7030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Jun 9, 2018
| <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory> | ||
| </Content> | ||
| <Content Include="..\Modules\Windows-Core\**\*;..\Modules\Windows-Core+Full\**\*;..\Modules\Shared\**\*"> | ||
| <Content Include="..\Modules\Windows\**\*;..\Modules\Shared\**\*"> |
Collaborator
There was a problem hiding this comment.
Ah, maybe we merge powershell-unix.csproj and powershell-win-core.csproj in one powershell-core.csproj to make file structure more simple?
Member
Author
There was a problem hiding this comment.
It's doable, but I'm not sure it will make the .csproj file simpler. There will be a bunch of conditions to separate the win-only and unix-only settings. Like RuntimeIdentifiers, content to publish (powershell.config.json, modules, install-powershellremoting.ps1 and ETW related files), and packages/projects to include.
So even after merging them into one file, it will look pretty diverged. I think it's cleaner to keep them separate, especially since we seldom change them :)
iSazonov
approved these changes
Jun 9, 2018
TravisEz13
approved these changes
Jun 11, 2018
adityapatwardhan
approved these changes
Jun 12, 2018
anmenaga
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR contains following changes:
Windows-Fullfolder undersrc/ModulesWindows-Core+FullandWindows-CoretoWindowsundersrc/ModulesNote: the
Microsoft.PowerShell.ODataUtilsmodule inWindows-Fullhas its own repository: https://github.com/PowerShell/ODataUtilsPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests