Skip to content

Remove SemanticVersion from list of KnownTypes for serialization #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Jun 8, 2018
Merged

Remove SemanticVersion from list of KnownTypes for serialization #7016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/System.Management.Automation/engine/serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5192,12 +5192,6 @@ internal static TypeSerializationInfo GetTypeSerializationInfoFromItemTag(string
InternalSerializer.WriteVersion,
InternalDeserializer.DeserializeVersion),

new TypeSerializationInfo(typeof(SemanticVersion),
SerializationStrings.SemanticVersionTag,
SerializationStrings.SemanticVersionTag,
InternalSerializer.WriteSemanticVersion,
InternalDeserializer.DeserializeSemanticVersion),

s_xdInfo,

new TypeSerializationInfo(typeof(ProgressRecord),
Expand Down
2 changes: 1 addition & 1 deletion test/powershell/engine/Basic/SemanticVersion.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ Describe "SemanticVersion api tests" -Tags 'CI' {
$ser = [PSSerializer]::Serialize($semver)
$des = [PSSerializer]::Deserialize($ser)

$des | Should -BeOfType System.Management.Automation.SemanticVersion
$des | Should -BeOfType System.Object
$des.ToString() | Should -Be $expectedResult
}
}
Expand Down