make macOS package use a consistent path #7006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leases and /usr/local/microsoft/powershell/6-preview for other releases.
TravisEz13
changed the title
rjmholt
approved these changes
Jun 5, 2018
Collaborator
rjmholt
left a comment
rjmholt
left a comment
There was a problem hiding this comment.
I've tested this out on Ubuntu 16.04 (i.e. package and install) and it works.
Tested as non-sudo, and package-install-package path. Works well.
Code changes look good.
| Test-IsPreview -version '6.1.0-sometthing' # returns true | ||
| Test-IsPreview -version '6.1.0' # returns false | ||
| #> | ||
| function Test-IsPreview |
Collaborator
There was a problem hiding this comment.
Only note here is that a string like "6.0.0-alpha.13-1557-gd67d87c" also passes this test. Just want to make sure that's intended behaviour (that string gets caught by the validation attribute so not a big concern).
Member
Author
There was a problem hiding this comment.
an alpha would be considered a preview. basically anything with a dash (-) in the version is a preview.
Member
Author
|
removing breaking change as the breaking part was made in a previous change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Address mac portions of PowerShell/PowerShell-RFC#115 (comment)
/usr/local/microsoft/powershell/6/usr/local/microsoft/powershell/6-previewand symlink name pwsh-previewAlso:
utimework around for mac requires sudoPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests