Minor update on 'GetFileSystemItem' #6984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
approved these changes
Jun 4, 2018
Contributor
There was a problem hiding this comment.
LGTM.
On a minor note: Would it not be more readable to determine if the file/directory exists as follows:
private static bool FileOrDirectoryExists(string path)
{
return (Directory.Exists(path) || File.Exists(path));
}Or is it a performance optimisation to just check the attributes instead?
iSazonov
approved these changes
Jun 4, 2018
Collaborator
There was a problem hiding this comment.
@daxian-dbw Thanks! Good catch!
@bergmeister Yes, the idea was to reduce kernel calls and extra path normalizations. Also we need process exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Submit minor updates to
GetFileSystemItem.I missed the review for #6909, and use this PR to address a few comments from myself :)
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests