Skip to content

Fix Windows Event Log channel isolation semantics #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Jun 14, 2018
Merged

Fix Windows Event Log channel isolation semantics #6956

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b28b23
Update PowerShell.Core.Instrumentation.man
Robo210 May 30, 2018
a780a9f
Remove admin channel
Robo210 Jun 6, 2018
70d054b
Update PowerShell.Core.Instrumentation.man
Robo210 Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 7 additions & 28 deletions src/PowerShell.Core.Instrumentation/PowerShell.Core.Instrumentation.man
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@
>
<events xmlns="http://schemas.microsoft.com/win/2004/08/events">
<!--Defines an event provider for PowerShell Core
The Guid for this provider should not be changed. If its
changed for any reason, then the manifest needs to be
first uninstalled and then installed again (using wevtutil)-->
The Guid for this provider should not be changed. If it's
changed for any reason, then the old manifest needs to be
first uninstalled and then the changed manifest installed
(using wevtutil)-->
<provider
guid="{f90714a8-5509-434a-bf6d-b1624c8a19a2}"
messageFileName="PowerShell.Core.Instrumentation.dll"
Expand Down Expand Up @@ -2186,10 +2187,11 @@
/>
</events>
<channels>
<!--There are two channels defined for Windows PowerShell instrumentation
<!--There are three channels defined for Windows PowerShell instrumentation
event provider
1. Operational - for high level diagnositc messages
1. Operational - for high level diagnostic messages
2. Analytic - for high volume high performance trace messages
3. Debug - for high volume high performance trace messages
-->
<channel
chid="C_OPERATIONAL"
Expand All @@ -2211,7 +2213,6 @@
<channel
chid="C_ANALYTIC"
enabled="false"
isolation="Application"
message="$(string.PS_CHANNEL_ANALYTIC.ChannelMessage)"
name="PowerShellCore/Analytic"
symbol="C_ANALYTIC"
Expand All @@ -2238,7 +2239,6 @@
<channel
chid="C_DEBUG"
enabled="false"
isolation="Application"
message="$(string.PS_CHANNEL_DEBUG.ChannelMessage)"
name="PowerShellCore/Debug"
symbol="C_DEBUG"
Expand All @@ -2262,27 +2262,6 @@
<bufferSize>64</bufferSize>
</publishing>
</channel>
<channel
chid="C_ADMIN"
enabled="true"
isolation="Application"
message="$(string.PS_CHANNEL_ADMIN.ChannelMessage)"
name="PowerShellCore/Admin"
symbol="C_ADMIN"
type="Admin"
>
<logging>
<!--this log is not circular, which means user has to
manually clear logs-->
<retention>true</retention>
<!--max size of the analytic log file is 100 MB.
It's ok to set it to this high a value because
this channel is not enabled by default and the
user will have to turn it on and this is the
maximum size as well-->
<maxSize>1048985600</maxSize>
</logging>
</channel>
</channels>
<levels>
<level
Expand Down