Fix Windows Event Log channel isolation semantics #6956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove isolation attribute from Analytic and Debug channels. These channel types always have an isolation of Custom. The Admin channel was enabled by default, but the comments for the channel indicated that it should be off by default and thus it is OK to use a huge file size and have it stop collecting events when the size is reached. This looks like a copy/paste error where the logging element was copied from a channel with a different isolation type, so fix it by duplicating the Operational channel's logging element instead. Since no events are being written to the Admin channel currently, set it to disabled by default.
daxian-dbw
approved these changes
Jun 6, 2018
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
Thanks @Robo210!
The changes look good to me.
@dantraMSFT Can you please take a look?
dantraMSFT
suggested changes
Jun 6, 2018
Contributor
dantraMSFT
left a comment
dantraMSFT
left a comment
There was a problem hiding this comment.
There's no reason to have an admin channel, it's not used for any events and I see no indication that it will change.
| </publishing> | ||
| </channel> | ||
| <channel | ||
| chid="C_ADMIN" |
Contributor
There was a problem hiding this comment.
Since there are no events referencing this channel, it should simply be removed, not disabled.
The admin channel is not used by any events, so remove it.
dantraMSFT
reviewed
Jun 6, 2018
| </events> | ||
| <channels> | ||
| <!--There are two channels defined for Windows PowerShell instrumentation | ||
| <!--There are four channels defined for Windows PowerShell instrumentation |
Contributor
There was a problem hiding this comment.
Sorry, I should have mentioned this before, you'll want to remove these comments around Admin as well.
Collaborator
|
Reopen The PR to restart CI Appveyor. |
Collaborator
|
@dantraMSFT Please update your review. |
dantraMSFT
approved these changes
Jun 14, 2018
Collaborator
|
@Robo210 Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove isolation attribute from Analytic and Debug channels. These channel types always have an isolation of Custom, regardless of what is put here in the manifest.
Since no events are being written to the Admin channel currently, remove it. This avoids the Windows Event Log pre-allocating a file for the channel.
PR Summary
Avoid setting incorrect values in the ETW manifest that get silently ignored by mc/wevtutil.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests