Scripts for building and testing PowerShell repository code on Linux on VSTS. #6953
Conversation
kalgiz
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
|
@kalgiz Is this YAML file for the Hosted Linux agent in VSTS or do you use your own agents? A comment in the yaml about the targeted platforms/agents would be good. Is this only for internal usage or will there be VSTS PR integration apart from the daily build? |
tools/linux_vsts.ps1
Outdated
| $repoRoot = Join-Path $PSScriptRoot '..' | ||
| Import-Module (Join-Path $repoRoot 'build.psm1') -Scope Global | ||
| $isPR = $env:BUILD_REASON -eq "PullRequest" | ||
| $commitMessage = git log --format=%B -n 1 $env:BUILD_SOURCEVERSION |
There was a problem hiding this comment.
$env:BUILD_SOURCEVERSIONMESSAGE would be an easier way of retrieving the commit message.
| # more info: https://docs.microsoft.com/en-us/rest/api/storageservices/fileservices/put-blob | ||
| $sb = [text.stringbuilder]::new() | ||
| # can't use AppendLine because the `r`n causes the command to fail, it must be `n and only `n | ||
| $null = $sb.Append("$method`n") |
There was a problem hiding this comment.
[System.Environment]::NewLine might be better than n. But if stringbuilder uses r`n on Linux, this sounds more like a bug in .Net Core (or maybe I misunderstood its usage)
tools/linux_vsts.ps1
Outdated
| # If there are failures, Test-XUnitTestResults throws | ||
| $SequentialXUnitTestResultsFile, $ParallelXUnitTestResultsFile | ForEach-Object { Test-XUnitTestResults -TestResultsFile $_ } | ||
| } | ||
| catch {} |
There was a problem hiding this comment.
why the empty catch block? If it is needed, therere should be a comment or the exception being logged.
kalgiz
force-pushed
the
linux-builds-on-vsts
branch
from
4947ce8 to
55b26c6
Compare
|
We plan to use the hosted agents |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
|
@TravisEz13 any way I can salvage this PR? |
|
@rjmholt I don't think this can be salvaged at this point. |
4 participants
PR Summary
Scripts for building and testing PowerShell repository code on Linux on VSTS.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature testsThis change is