Add "ValueFromPipelineByPropertyName = true" to all of the parameters of the Send-MailMessage cmdlet. #6911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the Send-MailMessage cmdlet.
sethvs
requested review from
JamesWTruher,
PaulHigin and
dantraMSFT
as code owners
Contributor
Author
|
If the changes are OK, docs will follow. |
daxian-dbw
approved these changes
Jun 15, 2018
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
LGTM. @BrucePay do you mind taking a quick look?
BrucePay
reviewed
Jun 26, 2018
Collaborator
BrucePay
left a comment
BrucePay
left a comment
There was a problem hiding this comment.
Looks good overall, I'd just like to see different data used in the second test.
| $ItArgs['Name'] = "Can send mail message from user to self using pipeline " + $ItArgs['Name'] | ||
|
|
||
| It @ItArgs { | ||
| $body = "Greetings from me." |
Collaborator
There was a problem hiding this comment.
I would suggest using distinguishable strings in this test i.e. "Greetings from me again" instead of "Greetings from me", "Second test message" instead of "Test message.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This would enable use cases when some other function gets needed information,
creates the PSCustomObject and send it to Send-MailMessage through the pipeline.
Get-NeededInfo | Send-MailMessageFix #6924
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests