Skip to content

Conversation

@DarwinJS
Copy link
Contributor

@DarwinJS DarwinJS commented May 10, 2018

PR Summary

Fixed #6815 by adding -allowprereleases parameter
Fixed #6405 by adding -allowprereleases parameter
Added parameters to documentation
Ready for prerelease repositories if Microsoft starts providing them
Added -skip-sudo-check for all distros
Fixed -interactivetesting should do nothing if -includeide was not used

PR Checklist

@TravisEz13 - If you create pre-release repos as per #6496 this switch can be used to add those repo links in the relevant distro install scripts. Currently it just issues a warning that whatever is on the repo dictates whether pre-releases will be installed.

@DarwinJS DarwinJS changed the title install-powershell.sh filter prereleases (when available), params documentation WIP: install-powershell.sh filter prereleases (when available), params documentation May 10, 2018
@DarwinJS
Copy link
Contributor Author

@TravisEz13 - I can't recall what to do about spelling errors in MD files - can you please remind me what we did last time?

@TravisEz13
Copy link
Member

You need to add the missing words in this section https://github.com/PowerShell/PowerShell/blob/master/.spelling#L215
image

@DarwinJS
Copy link
Contributor Author

@TravisEz13 - Looks like this is failing at the OSX sudo password prompt? How to handle this? Thanks! https://travis-ci.org/PowerShell/PowerShell/jobs/380487406

@TravisEz13
Copy link
Member

TravisEz13 commented May 21, 2018

@DarwinJS SUDO -v almost never works in CI. You'll have to update the code to skip this check. Or remove it altogether as unreliable.

@DarwinJS
Copy link
Contributor Author

DarwinJS commented May 22, 2018

Is there a way to detect CI? Is checking for POWERSHELL_TELEMETRY_OPTOUT=1 good enough or is there a better way?

There have not been any complaints about the sudo check (that I know of) beyond CI.

FYI - I updated the sudo check to be non-interactive.

@TravisEz13
Copy link
Member

most CI systems, except VSTS define a variable called CI. You can just doc that you expect that variable to be defined.

@DarwinJS DarwinJS requested a review from anmenaga as a code owner June 12, 2018 11:13
@DarwinJS
Copy link
Contributor Author

@TravisEz13 - I put in place the skipping of the sudo check, but also skipped sudo assuming I had admin.

So is the magic that I DO need to use SUDO - but I can't check for it?

How has this not been failing for months - it used to work without any special SUDO handling, but didn't break until I touched it.

Can you look at the build log?

@TravisEz13
Copy link
Member

My statement about sudo -v never working was too broad. It never worked in macOS, but other CI systems it doesn't work in debian. When in CI, we need to use sudo but not run sudo -v as it may fail. The equivalent of skip-sudo-check, these other systems is what I added this switch for. Just detecting CI and automatically skipping should be enough.

Also, you should look at the package renaming during preview.3 and see if this affects your change.

@DarwinJS DarwinJS closed this Jun 22, 2018
@DarwinJS DarwinJS reopened this Jun 22, 2018
@DarwinJS
Copy link
Contributor Author

@TravisEz13 - builds are passing - should I remove "WIP" ?

@TravisEz13 TravisEz13 changed the title WIP: install-powershell.sh filter prereleases (when available), params documentation install-powershell.sh filter prereleases (when available), params documentation Jun 25, 2018
@TravisEz13 TravisEz13 merged commit 53e6ec6 into PowerShell:master Jun 25, 2018
iSazonov pushed a commit that referenced this pull request Oct 1, 2018
* Fix syntax error for issue 7903. Typo come from #6849 

* Add identation after copyright message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants