Enable Web Cmdlets Tests for Greater Platform Support #6836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
approved these changes
May 8, 2018
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
@markekraus Please add comment in PR description why we can close this Issues. Is that because of moving to .Net Core 2.1 without curl?
Contributor
Author
|
#5492 is no longer relevant because 1) we have documented that for 6.0.0 in the IWR and IRM docs, 2) .NET Core 2.1 no longer has those dependencies, and 3) expanding these tests is proof that they are no longer an issue. |
TravisEz13
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
'Tls, Tls12'is not universally supported because it skipsTls11. This is not documented. in Web Cmdlets .NET Core 2.1 and PowerShell 6.1.0 Refresh MicrosoftDocs/PowerShell-Docs#2411-SslProtocoltests for macOS'Tls, Tls12'tests for non windows platforms. Support for skipping a protocol is not universal. it fails on CentOS 7 and macOS.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests