Skip to content

Quote Multipart/Form-Data Field Names #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
May 8, 2018
Merged

Quote Multipart/Form-Data Field Names #6782

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80c4a2c
[Feature] Quote Multipart Field names
markekraus Apr 30, 2018
2819151
[feature] empty commit. re-run CI
markekraus May 1, 2018
ae4207e
[Feature] Change $"" to +
markekraus May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1817,7 +1817,8 @@ private void AddMultipartContent(object fieldName, object fieldValue, MultipartF
private StringContent GetMultipartStringContent(Object fieldName, Object fieldValue)
{
var contentDisposition = new ContentDispositionHeaderValue("form-data");
contentDisposition.Name = LanguagePrimitives.ConvertTo<String>(fieldName);
// .NET does not enclose field names in quotes, however, modern browsers and curl do.
contentDisposition.Name = "\"" + LanguagePrimitives.ConvertTo<String>(fieldName) + "\"";

var result = new StringContent(LanguagePrimitives.ConvertTo<String>(fieldValue));
result.Headers.ContentDisposition = contentDisposition;
Expand All @@ -1833,7 +1834,8 @@ private StringContent GetMultipartStringContent(Object fieldName, Object fieldVa
private StreamContent GetMultipartStreamContent(Object fieldName, Stream stream)
{
var contentDisposition = new ContentDispositionHeaderValue("form-data");
contentDisposition.Name = LanguagePrimitives.ConvertTo<String>(fieldName);
// .NET does not enclose field names in quotes, however, modern browsers and curl do.
contentDisposition.Name = "\"" + LanguagePrimitives.ConvertTo<String>(fieldName) + "\"";

var result = new StreamContent(stream);
result.Headers.ContentDisposition = contentDisposition;
Expand All @@ -1850,7 +1852,8 @@ private StreamContent GetMultipartStreamContent(Object fieldName, Stream stream)
private StreamContent GetMultipartFileContent(Object fieldName, FileInfo file)
{
var result = GetMultipartStreamContent(fieldName: fieldName, stream: new FileStream(file.FullName, FileMode.Open));
result.Headers.ContentDisposition.FileName = file.Name;
// .NET does not enclose field names in quotes, however, modern browsers and curl do.
result.Headers.ContentDisposition.FileName = "\"" + file.Name + "\"";

return result;
}
Expand Down